bugfix - Prevent passwordstore lookup to create subkey when create == false #9106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false Fixes#9105
ansibullbot
added
bug
felixfontein
added
check-before-release
felixfontein
reviewed
Nov 7, 2024
changelogs/fragments/9106-passwordstore-fix-subkey-creation-even-when-create-==-false.yml
Outdated
Show resolved
Hide resolved
|
CC @mluzarreta |
…en-when-create-==-false.yml Co-authored-by: Felix Fontein <[email protected]>
|
Suggestions applied @felixfontein |
felixfontein
reviewed
Nov 8, 2024
| result.append(self.update_password()) | ||
| if self.paramvals["subkey"] != "password" and not self.passdict.get(self.paramvals['subkey']): # password exists but not the subkey | ||
| with self.opt_lock('write'): | ||
| result.append(self.update_password()) |
There was a problem hiding this comment.
I'm not sure whether this is correct. Right before the if, you're already running result.append(self.update_password()), and now, under a certain condition, you run it a second time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Prevent passwordstore lookup to create subkey when create == false
Fixes #9105
ISSUE TYPE
COMPONENT NAME
passwordstore lookup