Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size param #944

Closed
wants to merge 8 commits into from
Closed

Size param #944

wants to merge 8 commits into from

Conversation

Vovilla
Copy link

@Vovilla Vovilla commented Oct 12, 2023

The size ping parameter is in the doc example, but it is absent in options. Also size is absent in ping command template.

The error is looking as
fatal: [RT1]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (ios_ping) module: size. Supported parameters include: afi, count, dest, df_bit, egress, ingress, source, state, timeout, vrf."}

@Vovilla Vovilla temporarily deployed to ack October 12, 2023 13:55 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 12, 2023 13:57 Inactive
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #944 (103f293) into main (c9c5631) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   85.90%   85.90%           
=======================================
  Files         184      184           
  Lines       11944    11944           
=======================================
  Hits        10260    10260           
  Misses       1684     1684           

see 1 file with indirect coverage changes

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4e4e7d60f3844b7d97e81731a5513348

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 8m 41s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 19s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 24s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 22s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 30s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 12s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 05s

@Vovilla Vovilla temporarily deployed to ack October 12, 2023 14:29 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 12, 2023 14:30 Inactive
@Vovilla Vovilla temporarily deployed to ack October 12, 2023 14:39 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3b298a1c4a734c78b1d0c94f53ae7b8b

✔️ ansible-galaxy-importer SUCCESS in 3m 27s
✔️ build-ansible-collection SUCCESS in 8m 51s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 14s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 56s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 2m 53s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 40s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 04s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 09s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 51s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 19s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vovilla, thanks for the PR, as for the changelog, we generally don't edit this file, what we would usually do is add a yml file in the fragments folder which describes the change. Could you change this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that there are no changes to the argspec, could you also add this attribute to the argspec file and also i can see that the regex and facts have not been updated accordingly, could you please do that as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is automatically generated. Please don't edit this file manually.

@KB-perByte KB-perByte added the needs_info This issue requires further information. Please answer any outstanding questions. label Oct 25, 2023
@KB-perByte KB-perByte temporarily deployed to ack October 25, 2023 10:10 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ba22842beee849c8b24354cff5300038

✔️ ansible-galaxy-importer SUCCESS in 3m 34s
✔️ build-ansible-collection SUCCESS in 8m 45s
ansible-ee-integration-ios-latest NODE_FAILURE Node request 200-0006545835 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 27m 07s (non-voting)
ansible-ee-integration-ios-stable-2.11 NODE_FAILURE Node request 200-0006545850 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.12 NODE_FAILURE Node request 200-0006545854 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-latest NODE_FAILURE Node request 200-0006545851 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 28m 30s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 NODE_FAILURE Node request 200-0006545852 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 NODE_FAILURE Node request 200-0006545853 failed in 0s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 27s

@roverflow roverflow temporarily deployed to ack October 26, 2023 07:19 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7d334e89669240c587246a97732c3302

✔️ ansible-galaxy-importer SUCCESS in 11m 05s
✔️ build-ansible-collection SUCCESS in 9m 45s
ansible-ee-integration-ios-latest NODE_FAILURE Node request 200-0006548066 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 26s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 08s (non-voting)
ansible-ee-integration-ios-stable-2.12 NODE_FAILURE Node request 200-0006548067 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 41s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 54s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 09s (non-voting)
✔️ ansible-tox-linters SUCCESS in 15m 57s

@Vovilla Vovilla closed this by deleting the head repository Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_info This issue requires further information. Please answer any outstanding questions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants