-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size param #944
Size param #944
Conversation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 85.90% 85.90%
=======================================
Files 184 184
Lines 11944 11944
=======================================
Hits 10260 10260
Misses 1684 1684 |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 22s |
for more information, see https://pre-commit.ci
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 27s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Vovilla, thanks for the PR, as for the changelog, we generally don't edit this file, what we would usually do is add a yml file in the fragments folder which describes the change. Could you change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that there are no changes to the argspec, could you also add this attribute to the argspec file and also i can see that the regex and facts have not been updated accordingly, could you please do that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is automatically generated. Please don't edit this file manually.
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 34s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 11m 05s |
The size ping parameter is in the doc example, but it is absent in options. Also size is absent in ping command template.
The error is looking as
fatal: [RT1]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (ios_ping) module: size. Supported parameters include: afi, count, dest, df_bit, egress, ingress, source, state, timeout, vrf."}