Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ios_evpn_global resource module #892

Merged

Conversation

PadminiSivaraj
Copy link
Contributor

SUMMARY

Added ios_evpn_global resource module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_evpn_global resource module

@KB-perByte KB-perByte added the feature This issue/PR relates to a feature request. label Jul 27, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/117a071086984f7993471edfe9bb5a98

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 8m 41s
ansible-ee-integration-ios-latest FAILURE in 19m 16s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 19m 26s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 19m 23s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 19m 27s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 13m 04s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 08s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 52s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 02s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 20s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4069eddb567840d795efab91ba7603f6

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 8m 44s
ansible-ee-integration-ios-latest FAILURE in 14m 31s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 46s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 11s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 12m 33s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 53s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 36s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 28s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 10s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/62ee03711fc54ef8b2a0d02a215e0d26

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 8m 36s
ansible-ee-integration-ios-latest FAILURE in 15m 20s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 45s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 18s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 07s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 12m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 30s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 12m 45s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 21s

@KB-perByte KB-perByte self-requested a review July 28, 2023 07:47
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4a0b2fa3c9bf42dd8d5ee0fbe819e5f9

✔️ ansible-galaxy-importer SUCCESS in 6m 01s
✔️ build-ansible-collection SUCCESS in 8m 45s
ansible-ee-integration-ios-latest FAILURE in 17m 42s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 26s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 17s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 17m 01s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 16m 05s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 21m 20s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 16m 03s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 16m 03s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 22s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/961b68b347ac45419e8092494ce425c5

✔️ ansible-galaxy-importer SUCCESS in 4m 56s
✔️ build-ansible-collection SUCCESS in 8m 43s
ansible-ee-integration-ios-latest FAILURE in 18m 44s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 41s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 18m 23s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 18m 35s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 19m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 17m 46s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 16m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 16m 28s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 10s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3e6f13a786db412683447b2c5d5faedc

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 8m 53s
ansible-ee-integration-ios-latest FAILURE in 14m 21s (non-voting)
ansible-ee-integration-ios-stable-2.9 NODE_FAILURE Node request 200-0006243306 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 13m 17s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 10s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 15m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 47s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 27s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 17s (non-voting)
ansible-tox-linters FAILURE in 10m 36s

@PadminiSivaraj
Copy link
Contributor Author

Hello Sagar,
Some of the checks are failing, and it seems they are unrelated to the module that I have added. Could you please shed some light on this?
Thanks

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b7c46511712f4f37833e7a1b62245f85

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 8m 40s
ansible-ee-integration-ios-latest FAILURE in 13m 11s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 50s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 13m 21s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 13m 34s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 13m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 40s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 37s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 56s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 34s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2c461d93ded845159916a0bcb0ed34cd

✔️ ansible-galaxy-importer SUCCESS in 9m 39s
✔️ build-ansible-collection SUCCESS in 8m 55s
ansible-ee-integration-ios-latest FAILURE in 16m 09s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 11s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 16m 07s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 21s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 29s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 43s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 44s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 41s

@KB-perByte
Copy link
Collaborator

Hey @PadminiSivaraj there are a few review comments here please consider them the same for this PR
ansible-network/resource_module_models#230
Regards.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #892 (e7cb2e4) into main (79a733d) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   86.06%   86.20%   +0.14%     
==========================================
  Files         190      196       +6     
  Lines       12197    12339     +142     
==========================================
+ Hits        10497    10637     +140     
- Misses       1700     1702       +2     

see 7 files with indirect coverage changes

@PadminiSivaraj
Copy link
Contributor Author

Hello Sagar,
Thanks for your comments, I have addressed them.

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/131220f5569c4413873d3df1d0313431

✔️ ansible-galaxy-importer SUCCESS in 5m 06s
✔️ build-ansible-collection SUCCESS in 9m 24s
ansible-ee-integration-ios-latest FAILURE in 15m 49s (non-voting)
ansible-ee-integration-ios-stable-2.9 NODE_FAILURE Node request 200-0006331755 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 37s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 26s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 16s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 45s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 16m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 28s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 58s

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cisco.ios for 892,e25d2c3747bcf2de24dc2cb697b3c861ac5e07cc

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cisco.ios for 892,f2e295aa86a330ab5cf3086533a7dcbcd96c9f3c

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cisco.ios for 892,f444ac08d83d7113dbc9c544866dcc76f3cd62db

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cisco.ios for 892,0cfc2239af810bf9f0a61926e31c259d68323fad

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cisco.ios for 892,12ea8653c60df92b188dedfa158e764af9d0ece7

@PadminiSivaraj
Copy link
Contributor Author

Hello Sagar,
I have added config for Loopback1, and the integration tests are passing.
Thanks

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7f50f8b689744978a7af4b5af1858d10

✔️ ansible-galaxy-importer SUCCESS in 8m 05s
✔️ build-ansible-collection SUCCESS in 9m 55s
ansible-ee-integration-ios-latest RETRY_LIMIT in 6m 18s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 36m 24s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 6m 43s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 5m 42s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 50s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 30m 54s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 46s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 8m 33s (non-voting)
✔️ ansible-tox-linters SUCCESS in 20m 11s

@KB-perByte
Copy link
Collaborator

Hey @PadminiSivaraj
the integration tests are passing for ios_evpn_global, but the changes in this PR make the previously merged #897 module's test fail.
Adding the logs from dcloud session below,

......
                {
                    "default_gateway": {
                        "advertise": {
                            "disable": null,
                            "enable": true
                        }
                    },
                    "encapsulation": "vxlan",
                    "evi": 202,
                    "ip": null,
                    "replication_type": "static",
                    "route_distinguisher": null
                }
            ],
            "running_config": null,
            "state": "overridden"
        }
    }
}

TASK [ios_evpn_evi : Assert that correct set of commands were generated] *******
task path: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-vu1y_4d5-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/overridden.yaml:26
Loading collection ansible.utils from /home/cisco/test_collections/collections/ansible_collections/ansible/utils
<198.18.1.15> attempting to start connection
<198.18.1.15> using connection plugin ansible.netcommon.network_cli
Found ansible-connection at path /home/cisco/ansible/bin/ansible-connection
<198.18.1.15> found existing local domain socket, using it!
<198.18.1.15> updating play_context for connection
<198.18.1.15> Loading collection ansible.builtin from 
<198.18.1.15> local domain socket path is /home/cisco/.ansible/pc/d02af7d5fa
fatal: [198.18.1.15]: FAILED! => {
    "assertion": false,
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

TASK [ios_evpn_evi : ansible.builtin.include_tasks] ****************************
task path: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-vu1y_4d5-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/overridden.yaml:50
redirecting (type: action) cisco.ios.ios_evpn_evi to cisco.ios.ios
included: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-vu1y_4d5-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/_remove_config.yaml for 198.18.1.15
redirecting (type: action) cisco.ios.ios_evpn_evi to cisco.ios.ios
****

The tests for ios_evpn_evi were passing before we merged it but for some configuration updates that were done via this PR i.e ios_evpn_global it's making the tests for ios_evpn_evi fail.
Could you please take a look?
Regards.

@KB-perByte KB-perByte merged commit 8951167 into ansible-collections:main Nov 16, 2023
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants