Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keychain: Shielded Key is changed after upgrading account #1504

Open
Rigorously opened this issue Jan 12, 2025 · 6 comments
Open

Keychain: Shielded Key is changed after upgrading account #1504

Rigorously opened this issue Jan 12, 2025 · 6 comments
Assignees
Labels
App: Extension bug Something isn't working
Milestone

Comments

@Rigorously
Copy link

When updating an account that was created during the dry-run, the shielded keypair changes.

Importing the account into the CLI derives the original shielded keypair.

See discussion on Discord: https://discord.com/channels/833618405537218590/1144469159137247283/1327819454977146961

@jurevans jurevans added bug Something isn't working App: Extension labels Jan 13, 2025
@jurevans jurevans added this to the Phase 3 milestone Jan 13, 2025
@Rigorously
Copy link
Author

For anyone trying to reproduce this with an old (dry-run) account:

  • Go to https://interface.campfire.tududes.com/
  • Write down the old account's Shielded Address, Viewing Key, transparent balance and shielded balance
  • Create a new account and fund it with 1000 NAM from the faucet https://faucet.campfire.tududes.com/
  • Shield 400 NAM from the new transparent account to its Shielded Address
  • Wait for the MASP to update. The new account should have 400 NAM in the MASP
  • Transfer 5 NAM from the new account's Shielded Address to the old account's Shielded Address
  • Wait for the MASP to update. The old account's shielded balance should have increased by 5 NAM
  • Delete and reimport the old account
  • Write down the reimported account's Shielded Address, Viewing Key, transparent balance and shielded balance
  • Transfer 3 NAM from the new account's Shielded Address to the reimported Shielded Address

If the Shielded Address is unchanged, then the Shielded balance should be 8 NAM.
If it was changed, then there is 3 NAM on Namadillo and 5 NAM when importing in the CLI.

@msobh13
Copy link

msobh13 commented Jan 15, 2025

I just tested it . Shielded amount increased by 5 then 3 so final amount is 8 . I think I was not able to reproduce the behavior you faced .
used 2 Chrome profiles with Old wallet from CB and New wallet created today . and followed the steps .

final results : Shielded Address is unchanged and Shielded balance should be 8 NAM.

Keychain Version: 0.3.7 Revision: [09241847 ](https://github.com/anoma/namada-interface/commit/09241847bc18f663faa2bc03af052f1afa2fca83) SDK Version: 0.14.0

@opsecx
Copy link

opsecx commented Jan 16, 2025

Didn't follow all the steps in your example, but did verify the shielded address (znam) remained same. Viewing key changed.

@mateuszjasiuk
Copy link
Collaborator

mateuszjasiuk commented Jan 16, 2025

Hey guys,
Thank you for reporting this. This change is related to ongoing work to support zip32 with ledger device. We are still having internal discussion about it and we will give you an update soon. We should've communicated it better, sorry for that!

@msobh13

This comment has been minimized.

@mateuszjasiuk
Copy link
Collaborator

@msobh13 I've hidden your comment and referenced it in #1561 so it does not obfuscate the topic here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Extension bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants