You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
Oh, wow. Thanks for the detective work! I was vaguely aware of the issue, but never looked into it because it didn't seem to break crucial functionality. (And, also, I admit, because the Ellipse plugin was a 3rd party contribution.)
I made that tiny fix. Didn't publish an updated version of the package yet. But will do soon. For context: the drawEllipse call in line 20 of RubberbandEllipse simply creates an initial tiny ellipse when the user first starts drawing. This initial ellipse is supposed to have an (arbitrarily chosen) radius of 2px, and will then follow the mouse as the user draws. Looks like the initial call only set the x-radius, but should also have set a y-radius.
As I said: fixed now - many thinks for debugging this!
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I read through the other issues, seems like this console error:
Was mentioned in another issue, but not discussed. I dug deeper to see what the problem is, and found that on this line:
annotorious-v2-selector-pack/src/ellipse/RubberbandEllipse.js
Line 20 in bea78d6
drawEllipse
method, when the method itself expects 4:annotorious-v2-selector-pack/src/ellipse/Ellipse.js
Line 15 in bea78d6
This then gets pushed into
annotorious-v2-selector-pack/src/ellipse/Ellipse.js
Line 4 in bea78d6
annotorious-v2-selector-pack/src/ellipse/Ellipse.js
Line 8 in bea78d6
Not sure what the 4th expected value is supposed to be, but figured this would make it easier to debug.
Thanks for looking!
The text was updated successfully, but these errors were encountered: