Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

ShapeLabels doesn't show label when tag has a URI #41

Open
R-W-C opened this issue Oct 4, 2023 · 1 comment
Open

ShapeLabels doesn't show label when tag has a URI #41

R-W-C opened this issue Oct 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@R-W-C
Copy link

R-W-C commented Oct 4, 2023

If you use the Shape Labels plugin and you use the TAG widget (initilialize Annatorious with this option), a label is showed, but the text is "undefined".

See https://codepen.io/r-w-c/pen/abPRBbW

Reproduce:

  • SHIFT + LEFT MOUSE CLICK to draw a circle
  • in the tag field, click down arrow on keyboard and select an item from the dropdown
  • click OK

Expected result: shape label contains text of selected tag
Actual result: shape label contains "undefined

undefined
"

@rsimon rsimon changed the title Bug: Annotorious Shape Labels doesn't show first tag when using TAG widget ShapeLabels doesn't show labe when tag has a URI Oct 4, 2023
@rsimon rsimon added the bug Something isn't working label Oct 4, 2023
@rsimon
Copy link
Member

rsimon commented Oct 4, 2023

Thx. Can reproduce!

This happens only for tags with URIs. P.S.: If anyone wants to pick this up: this would actually be a simple fix. URI-tags have a slightly different structure than string tags. Fix would have to be here:

https://github.com/annotorious/annotorious-v2-plugins/blob/main/plugins/annotorious-shape-labels/src/index.js#L21

@R-W-C R-W-C changed the title ShapeLabels doesn't show labe when tag has a URI ShapeLabels doesn't show label when tag has a URI Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants