Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoMethodError when no request and cookies == :none #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NoMethodError when no request and cookies == :none #554

wants to merge 1 commit into from

Commits on Apr 12, 2024

  1. Fix NoMethodError when cookies == :none 

    When tracking with no request,

```
Ahoy.cookies = :none
Ahoy::Tracker.new.track_event(:would_fail)
```

would raise NoMethodError: undefined method `remote_ip' for nil.
Since we explicitly don't have a request, allow visitor_token_helper
to fall back on generate_id by returning nil from visitor_anonymity_set
when there is no request.
    @rgarner
    rgarner committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b3c2b8c View commit details
    Browse the repository at this point in the history