Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Command hotkey for macOS #13

Open
4 tasks
justkd opened this issue Jul 25, 2018 · 0 comments
Open
4 tasks

Command hotkey for macOS #13

justkd opened this issue Jul 25, 2018 · 0 comments

Comments

@justkd
Copy link
Contributor

justkd commented Jul 25, 2018

Description

All hotkeys are bound to ctrl right now. The command modifier does not work exactly the same as ctrl and alt.

For mac users, command is more familiar and should be the default modifier.

Also, preventDefault isn't preventing browser hotkeys from activating. Should be another method to manage this (many web apps properly use command for hotkeys).

Not tested: it's possible that the ctrl hotkeys are not working in windows for a similar reason. I don't have a readily available windows machine for convenient testing.

Acceptance Criteria

Update [Required]

  • command should be the default modifier for hotkeys on macOS
  • Ensure ctrl and command hotkeys work as expected on their respective platforms

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant