You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 5, 2020. It is now read-only.
All hotkeys are bound to ctrl right now. The command modifier does not work exactly the same as ctrl and alt.
For mac users, command is more familiar and should be the default modifier.
Also, preventDefault isn't preventing browser hotkeys from activating. Should be another method to manage this (many web apps properly use command for hotkeys).
Not tested: it's possible that the ctrl hotkeys are not working in windows for a similar reason. I don't have a readily available windows machine for convenient testing.
Acceptance Criteria
Update [Required]
command should be the default modifier for hotkeys on macOS
Ensure ctrl and command hotkeys work as expected on their respective platforms
Definition of Done
All of the required items are completed.
Approval by 1 mentor.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
All hotkeys are bound to
ctrl
right now. Thecommand
modifier does not work exactly the same asctrl
andalt
.For mac users,
command
is more familiar and should be the default modifier.Also,
preventDefault
isn't preventing browser hotkeys from activating. Should be another method to manage this (many web apps properly use command for hotkeys).Not tested: it's possible that the
ctrl
hotkeys are not working in windows for a similar reason. I don't have a readily available windows machine for convenient testing.Acceptance Criteria
Update [Required]
command
should be the default modifier for hotkeys on macOSctrl
andcommand
hotkeys work as expected on their respective platformsDefinition of Done
The text was updated successfully, but these errors were encountered: