Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for User info API #78

Open
1 of 3 tasks
isabelcosta opened this issue Feb 14, 2021 · 9 comments
Open
1 of 3 tasks

Create unit tests for User info API #78

isabelcosta opened this issue Feb 14, 2021 · 9 comments
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Hacktoberfest Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Testing UI Tests, Integration Tests, Travis CI, etc.

Comments

@isabelcosta
Copy link
Member

Description

As a developer,
I need have unit tests for each functionality,
so that I can be confident when building a new feature, that there are no regression on the platform.

API: GET /api/info

The idea is to come with 3 unit tests to test this API. You may have to mock some information to properly test it.

Resources:

Acceptance Criteria

Update [Required]

  • Create 3 unit tests for GET /api/info API

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

4 hours

@isabelcosta isabelcosta added Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Type: Testing UI Tests, Integration Tests, Travis CI, etc. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Feb 14, 2021
@decon-harsh
Copy link
Member

@isabelcosta I would love to take this up!

@isabelcosta
Copy link
Member Author

It's yours @decon-harsh :)

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 14, 2021
@isabelcosta isabelcosta changed the title Create unit tests for GET user info API Create unit tests for User info API Feb 14, 2021
@b-thebest
Copy link

This issue is completed, or still something needs to be done ?

@decon-harsh
Copy link
Member

decon-harsh commented Mar 8, 2021

I have to mock the zulip functionalities @b-thebest

@isabelcosta
Copy link
Member Author

@b-thebest could you help reviewing the PR? #94
Also, @decon-harsh do you need help mocking zulip functionalities? also, did you update your branch? the tests are now passing on branches, because of recent merges

@decon-harsh
Copy link
Member

Also, @decon-harsh do you need help mocking zulip functionalities? also, did you update your branch? the tests are now passing on branches, because of recent merges

@isabelcosta i updated my branch , but still the tests are falling , it's because of a migration issue .

Comming to mocking zulip functionalities I might need some more time as I am working on an issue in BIT and I have exams too this week ! I will try to do as soon as possible. Will this works or I should prioritise it above?

@isabelcosta
Copy link
Member Author

isabelcosta commented Mar 8, 2021

If you could provide an update on this, in the next 3 days is fine, according to our contributing guidelines. It's also okay, to leave this issue if you prefer @decon-harsh
I'll take a look at your PR, to see what is failing

@decon-harsh
Copy link
Member

If you could provide an update on this, in the next 3 days is fine, according to our contributing guidelines. It's also okay, to leave this issue if you prefer @decon-harsh
I'll take a look at your PR, to see what is failing

Yes that will work. I will try to do it asap! Thank you

@b-thebest
Copy link

@b-thebest could you help reviewing the PR? #94
Also, @decon-harsh do you need help mocking zulip functionalities? also, did you update your branch? the tests are now passing on branches, because of recent merges

Yeah sure

@codesankalp codesankalp added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Quality Assurance Changes to code or files that improve testing or fixes bugs. Hacktoberfest Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
4 participants