Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

MenuItem gallery example needs to be updated from deprecated action to actionWithConext #437

Open
supermuka opened this issue Sep 17, 2019 · 1 comment

Comments

@supermuka
Copy link

The analyzer shows the following message to MenuItem component:

'action' is deprecated and shouldn't be used.

However, the example in AngularDart Gallery is implemeting the deprecated action:

Material Menu/MaterialMenuDemoComponent
/Source Code

Into MenuItem source code we have:

  MenuItem(this.label,
      { "...", 
      @Deprecated('Use ActionWithContext') MenuAction action,
      ActionWithContext actionWithContext,
       "..." })

It seems that the example needs to be updated.

Environment:
Dart VM version: 2.6.0-dev.1.0
angular_components: version: "0.14.0-alpha+1"

@nshahan
Copy link
Contributor

nshahan commented Sep 18, 2019

Good catch, thanks for pointing it out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants