Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

dialog(multiple): main dialog (clickOutsideToClose: false) is closed when nested dialog is opened #11828

Open
Vadymchyk opened this issue Dec 10, 2019 · 5 comments
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P4: minor Minor issues. May not be fixed without community contributions. type: bug
Milestone

Comments

@Vadymchyk
Copy link

Vadymchyk commented Dec 10, 2019

Bug, enhancement request, or proposal:

Bug

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

https://codepen.io/vadymchyk/pen/yLyOOPX

Detailed Reproduction Steps:

Create two multiple dialogs
First:
clickOutsideToClose: false,
escapeToClose: false,
Second (nested):
clickOutsideToClose: true,
multiple: true,

  1. Open the first dialog
  2. Open the second dialog(multiple)
  3. Press "Esc" or click outside when the second dialog is opening (during animation)

What is the expected behavior?

The first dialog stay opened

What is the current behavior?

The first dialog is closed

What is the use-case or motivation for changing an existing behavior?

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.8
  • AngularJS Material: 1.1.20
  • OS: all
  • Browsers: all

Is there anything else we should know? Stack Traces, Screenshots, etc.

@Splaktar Splaktar added the needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue label Dec 27, 2019
@Splaktar
Copy link
Member

Did you change something with your CodePen reproduction after posting it? When I test it in Chrome Version 79.0.3945.88 or Firefox 70.0.1 on macOS, I see the first dialog stay opened as you expected.

@Splaktar Splaktar added the resolution: can't reproduce The team is unable to reproduce this issue with the information provided label Dec 27, 2019
@Vadymchyk
Copy link
Author

Vadymchyk commented Dec 27, 2019

I have not changed anything. The bug is still reproduced:
https://www.youtube.com/watch?v=gk-_vwSK1cw

@Splaktar Splaktar reopened this Dec 27, 2019
@Splaktar
Copy link
Member

Thank you for sharing the video. I'm not able to reproduce that behavior.

Are you on Windows?

What browser and version are you using?

@Vadymchyk
Copy link
Author

Reproduced on macOS 10.15.2:
Google Chrome Version 79.0.3945.88 (Official Build) (64-bit)
Safari Version 13.0.4 (15608.4.9.1.3)

and I saw this bug on Windows machine too.

@Splaktar Splaktar removed needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue resolution: can't reproduce The team is unable to reproduce this issue with the information provided labels Nov 15, 2020
@Splaktar
Copy link
Member

OK, I can reproduce this if I do this critical part of the reproduction steps

when the second dialog is opening (during animation)

The ESCAPE shouldn't close the first dialog with escapeToClose: false, but it does. This does certainly seem like a buggy edge case.

@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. type: bug labels Nov 15, 2020
@Splaktar Splaktar added this to the - Backlog milestone Nov 15, 2020
@Splaktar Splaktar added for: external contributor needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P4: minor Minor issues. May not be fixed without community contributions. type: bug
Projects
None yet
Development

No branches or pull requests

2 participants