Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

build: interimElements and Layout code not deterministically ordered #11727

Open
Splaktar opened this issue May 21, 2019 · 1 comment
Open

build: interimElements and Layout code not deterministically ordered #11727

Splaktar opened this issue May 21, 2019 · 1 comment
Assignees
@Splaktar
Labels
g3: reported The issue was reported by an internal or external product team. needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P4: minor Minor issues. May not be fixed without community contributions. type: build
Milestone
- Backlog

Comments

@Splaktar
Copy link
Member

Bug, enhancement request, or proposal:

Bug

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

angular/bower-material@31ac6b3#diff-df9d3e2ee1137430619e1984b3c34f3b

Detailed Reproduction Steps:

  1. Merge a change into the master branch
  2. Then check that the code in bower-material/modules/closure/core/core.js is re-ordered

What is the expected behavior?

The order of the code is deterministic.

What is the current behavior?

The order of the code is non-deterministic. In this case, the order of the src/core/services/layouts and src/core/services/interimElement code was swapped.

What is the use-case or motivation for changing an existing behavior?

So that only real changes show up in the module diffs.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.8
  • AngularJS Material: 1.1.18-master-d577afd
  • OS: macOS
  • Browsers: Chrome

Is there anything else we should know? Stack Traces, Screenshots, etc.

Related to #11502.
@Splaktar Splaktar self-assigned this May 21, 2019
@Splaktar Splaktar added this to the 1.1.19 milestone May 21, 2019
@Splaktar Splaktar added P2: required Issues that must be fixed. type: build needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels May 21, 2019
@Splaktar Splaktar added g3: reported The issue was reported by an internal or external product team. g3: sync labels May 30, 2019
@Splaktar Splaktar modified the milestones: 1.1.19, 1.1.20 May 30, 2019
@Splaktar Splaktar modified the milestones: 1.1.20, 1.1.21 Aug 15, 2019
@Splaktar Splaktar modified the milestones: 1.1.21, 1.1.22 Sep 30, 2019
@Splaktar Splaktar modified the milestones: 1.1.22, 1.1.23 Oct 22, 2019
@Splaktar Splaktar modified the milestones: 1.1.23, 1.2.1 Jun 8, 2020
@Splaktar Splaktar modified the milestones: 1.2.1, 1.2.2 Sep 14, 2020
@Splaktar Splaktar added P4: minor Minor issues. May not be fixed without community contributions. and removed P2: required Issues that must be fixed. labels Oct 20, 2020
@Splaktar Splaktar modified the milestones: 1.2.2, - Backlog Oct 20, 2020
@Splaktar
Copy link
Member Author

Lowering priority since g3 sync has stopped.

@Splaktar Splaktar removed the g3: sync label Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
g3: reported The issue was reported by an internal or external product team. needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community P4: minor Minor issues. May not be fixed without community contributions. type: build
Projects
None yet
Milestone
- Backlog
Development

No branches or pull requests
1 participant
@Splaktar