Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ES6 export in TypeScript definitions #177

Closed
smrq opened this issue Nov 30, 2017 · 7 comments
Closed

Fix ES6 export in TypeScript definitions #177

smrq opened this issue Nov 30, 2017 · 7 comments

Comments

@smrq
Copy link

smrq commented Nov 30, 2017

This commit broke importing this module from TypeScript: 0f9fe17#diff-b52768974e6bc0faccb7d4b75b162c99

The following TypeScript code should work:

import ngRedux from 'ng-redux';

After this commit, which removes the default export from the typings, this fails with the following error:

error TS1192: Module '"/path/to/node_modules/ng-redux/index"' has no default export.
@ionutVizitiu
Copy link

Hi,

I think also that the whole commit should be reverted.
Is there any reason to keep it like this?

@cristianmartinez
Copy link

Same problem here.

@AntJanus
Copy link
Collaborator

AntJanus commented Feb 2, 2018

I'll go ahead and merge that PR in.

@ionutVizitiu
Copy link

Thank you @AntJanus .
Any idea when you have some time for that?

@AntJanus
Copy link
Collaborator

AntJanus commented Feb 7, 2018

@ionutVizitiu doing 4.0 release tonight.

@ionutVizitiu
Copy link

ionutVizitiu commented Feb 13, 2018

Thank you very much @AntJanus !
I appreciate your work.

I saw you've export default ngRedux;. Unfortunately, this is not enough for typings to work. We still need to remove the namespace too.

@ionutVizitiu
Copy link

I've created this PR #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants