Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an effect to listen for multiple different actions #44

Open
Chudroy opened this issue Apr 24, 2024 · 2 comments
Open

Allow an effect to listen for multiple different actions #44

Chudroy opened this issue Apr 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Chudroy
Copy link

Chudroy commented Apr 24, 2024

with original ngrx store, you can have

  effect$ = createEffect(
    () =>
      this.actions$.pipe(
        ofType(Actions.action1, Actions.action2),
        tap(() => this.service.doSomething())
      ),
  )

the ofType allowing multiple actions as arguments. However this is not the case with the create function within the effects of WithRedux in the signal store.

@Chudroy Chudroy changed the title Allow an effect to listen for multiple actions Allow an effect to listen for multiple different actions Apr 24, 2024
@Chudroy
Copy link
Author

Chudroy commented Apr 24, 2024

by the way thank you for implementing my previously requested features!

@rainerhahnekamp
Copy link
Collaborator

Sure thing, please continue giving feedback and requesting features. The whole ngrx-toolkit would be worthless if nobody uses it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants