Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support #444

Open
ryjogo opened this issue Mar 21, 2022 · 4 comments
Open

Proxy support #444

ryjogo opened this issue Mar 21, 2022 · 4 comments
Labels
needs triage Ticket that needs triage (a proper look for classification)

Comments

@ryjogo
Copy link

ryjogo commented Mar 21, 2022

Describe the bug

I'm setting HTTP_PROXY, HTTPS_PROXY and NO_PROXY env vars, but it seems the Jira Client isn't taking these into use.

@github-actions
Copy link

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

@ryjogo
Copy link
Author

ryjogo commented Mar 21, 2022

Might have found a workaround, but why doesn't it support the standard OS env vars?

	url_i := url.URL{}
	url_proxy, _ := url_i.Parse("http://IP:PORT/")

	tr := &http.Transport{
		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
		Proxy:           http.ProxyURL(url_proxy),
	}

	tp := jira.BasicAuthTransport{
		Username:  user,,
		Password:  pass,
		Transport: tr,
	}

@benjivesterby
Copy link
Contributor

As a library adherence to environment variables would be out of scope.

@andygrunwald andygrunwald added the needs triage Ticket that needs triage (a proper look for classification) label Aug 20, 2022
@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library.
If there is anything else you would like to tell us, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Ticket that needs triage (a proper look for classification)
Projects
None yet
Development

No branches or pull requests

3 participants