Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent time fields #267

Open
kfoxb opened this issue Mar 31, 2020 · 6 comments
Open

Inconsistent time fields #267

kfoxb opened this issue Mar 31, 2020 · 6 comments
Labels
good for beginner help wanted needs triage Ticket that needs triage (a proper look for classification) v2 waiting for feedback

Comments

@kfoxb
Copy link
Contributor

kfoxb commented Mar 31, 2020

I've noticed that there are some fields on some of the types, in particular the Comment struct, that are strings instead of a jira.Time. Is there a reason for this? It would be a breaking change, but would you be open to a pull request to change these fields to be jira.Time instead?

@bored-engineer
Copy link
Contributor

Another option (avoiding a breaking change) would be to at least implement helper methods similar to ChangelogHistory.CreatedTime.

@andygrunwald
Copy link
Owner

@kfoxb The reason might be that jira.Time was introduced later and not fully adjusted to all types.
Indeed, this would be a breaking change. And maybe it is time for a breaking change + v2. We have more and more such changes.

Would you be open to prepare such a PR to make it consistent across the library?

@perolo
Copy link

perolo commented May 19, 2020

I have a more general question regarding how to use/access/cast of the Time data?
https://stackoverflow.com/questions/61897115/fail-to-access-cast-time-time

@perolo
Copy link

perolo commented May 19, 2020

I was so sure that I tested and failed with:
resDate=time.Time(issue.Fields.Resolutiondate)
But that solves my problem
....

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 19, 2020
@andygrunwald andygrunwald added needs triage Ticket that needs triage (a proper look for classification) v2 labels Aug 20, 2022
@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library.
If there is anything else you would like to tell us, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good for beginner help wanted needs triage Ticket that needs triage (a proper look for classification) v2 waiting for feedback
Projects
None yet
Development

No branches or pull requests

4 participants