Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapless playback regression #105

Open
andrewrk opened this issue Aug 28, 2015 · 1 comment
Open

gapless playback regression #105

andrewrk opened this issue Aug 28, 2015 · 1 comment
Labels
bug ffmpeg-bug

Comments

@andrewrk
Copy link
Owner

After switching to ffmpeg we've lost gapless playback and a tiny glitch can be heard between songs.
@andrewrk andrewrk added the bug label Aug 28, 2015
@andrewrk andrewrk added this to the 5.0.0 milestone Aug 28, 2015
@andrewrk
Copy link
Owner Author

More details: this has happened specifically with ogg vorbis files. After converting the danse macabre examples to FLAC gapless playback was restored.

Further, the problem is av_seek_frame seeking to 0. If I remove that, the playlist example succeeds. Note that removing that is not a workable solution however, since we need the seek in case multiple queue items reference the same file, or if the user chooses to play the previous song.

andrewrk added a commit that referenced this issue Aug 29, 2015
@andrewrk
optimization: don't seek to 0 the first time
b7c3d6c 
mitigates #105 but does not solve it.

After we open a file, we are at the beginning of the file.
So if we get a seek request for 0 and we haven't seeked yet,
we ignore it. This works around glitches caused by ffmpeg's
seeking algorithm.

However, it does not solve the case where the user seeks to
a previous item on the playlist and then a file which has already
been played comes up again.
@andrewrk andrewrk removed this from the 5.0.0 milestone Aug 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ffmpeg-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewrk