Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The top attribute of the background is calculated incorrectly for Messages and other header icons #32

Open
gedion opened this issue Mar 3, 2017 · 0 comments

Comments

@gedion
Copy link

gedion commented Mar 3, 2017

As you can see in the below image, with clean theme, the background container should be highlighting the messaging icon. But because of the sticky header and scrolling, the offset is incorrectly calculated.

This seems to be happening in the method Tour.prototype.positionBackdrop in usertours/amd/src/tour.js

I've also noticed that the positionBackdrop is being called in Tour.prototype.addStepToPage method before scroll animation is triggered. Calling Tour.prototype.positionBackdrop after the scroll animation seems to fix this issue but I do not know if it is appropriate to do so.

screen shot 2017-03-03 at 9 27 37 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant