Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Main Css Styling in Admin Panel #104

Closed
andreknieriem opened this issue Oct 8, 2019 · 14 comments · Fixed by #218
Closed

Feature request: Main Css Styling in Admin Panel #104

andreknieriem opened this issue Oct 8, 2019 · 14 comments · Fixed by #218
Assignees
Milestone

Comments

@andreknieriem
Copy link
Owner

Hey everybody. I have a new idea for the photobooth. In some of my earlier projects I implemented a wordpress theme with color-picker options. I think this could be a nice feature.

Here is an image of the backend:
image

To not conflict the scss styling, maybe we can use this:
https://leafo.net/scssphp/docs/ it is a php scss compiler. So we can load the scss file and set the variables from the admin panel to generate the new css.

I have used https://www.eyecon.ro/colorpicker/ to pick the color. I like it. What are you thinking? Maybe with some drag/drop upload for background images?

@andi34
Copy link
Collaborator

andi34 commented Oct 8, 2019

I think this is a good idea.
To change the background via admin panel was requested once (#57) which I added to the feature request collection issue/thread.

To not have to many conflicts later I'd wait for #90 to be merged, as the code is rewritten in many parts.

@andi34
Copy link
Collaborator

andi34 commented Oct 8, 2019

@sualko
Copy link
Collaborator

sualko commented Oct 8, 2019

No need to use a php scss compiler, because feature/refactor uses css vars and feature/misc even supports custom colors from the config file. Therefore only the admin page has to be modified. I personally would prefer to use the html5 input type color, which has a pretty good browser support.

@andi34 andi34 added the feature label Oct 8, 2019
@andi34 andi34 mentioned this issue Oct 8, 2019
21 tasks
@sualko sualko added this to the v2.1.0 milestone Oct 11, 2019
@msmedien
Copy link

Is it possible to integrate an option for the font-size of the buttons? On a screen resolution of 1920x1080 is the text extremly small and i need to adjust it after every update manually in the css file. :/

Or is it possible to include the btn. class in this way, that for different screen resolution a different font-size is set as standard? :) Thanks a lot :)

@sualko
Copy link
Collaborator

sualko commented Oct 16, 2019

@msmedien please open another issue for your request, because otherwise can't organize all requests and the author of this issues gets notifications for your discussion.

@andi34
Copy link
Collaborator

andi34 commented Jan 13, 2020

As information: I am working on it.

Screenshot_20200112-134123__01

@andreknieriem
Copy link
Owner Author

Looks very nice!

@andi34
Copy link
Collaborator

andi34 commented Jan 13, 2020

My current WIP implementation would also fix #198 as the color for Cheese!, Countdown and the background can be adjusted seperately (same color, e.g. black = no text visible)

andi34 added a commit to andi34/photobooth that referenced this issue Jan 15, 2020
- NOTE: type="color" is not supported in Internet Explorer 11
  or Safari 9.1 (or earlier)

Fix andreknieriem#104
Fix andreknieriem#198 (countdown-background
and countdown-color can be set to same color)

Change-Id: I1cf2536a3feba760f5ba33827608cec440db966f
andi34 added a commit to andi34/photobooth that referenced this issue Jan 15, 2020
- NOTE: type="color" is not supported in Internet Explorer 11
  or Safari 9.1 (or earlier)

Fix andreknieriem#104
Fix andreknieriem#198 (countdown-background
and countdown-color can be set to same color)

Change-Id: I1cf2536a3feba760f5ba33827608cec440db966f
@flighter18
Copy link

Good morning @andi34

Would it be a big task to distinguish font color between back-end and front-end?

If you choose white as text color, the front-end look nice:
white-color-interface

But you can't read the font in the admin panel, if the panel color is white:
color-admin

@andi34
Copy link
Collaborator

andi34 commented Jan 16, 2020

@flighter18 you need to adjust the "admin and login panel color" if you like to use white text

@andi34
Copy link
Collaborator

andi34 commented Jan 16, 2020

"Field color" maybe too

@flighter18
Copy link

@flighter18 you need to adjust the "admin and login panel color" if you like to use white text

I already know that. but if i like the white background in the admin panel (for me the most readable) i have no opportunity to change the font color to white :)

@andi34
Copy link
Collaborator

andi34 commented Jan 16, 2020

Revert 2a1da4e if you don't need/like to change the font color on start screen

@andi34
Copy link
Collaborator

andi34 commented Jan 16, 2020

46237d9
I'll merge/push that later here too.

Edit:
Pushed.

My work is done here. Future work continues on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants