Change BUILD_INSIGHTS_OUTSIDE_LLVM to an option to allow customization

[Freed-Wu]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (cba412f) to head (6dcd688).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          20       20           
  Lines        6527     6527           
=======================================
  Hits         6386     6386           
  Misses        141      141           

Flag	Coverage Δ
insights-macos	97.10% <ø> (ø)
insights-ubuntu-amd64-libcxx-No	98.08% <ø> (ø)
insights-ubuntu-amd64-libcxx-Yes	98.06% <ø> (ø)
insights-ubuntu-arm64-libcxx-No	98.04% <ø> (ø)
insights-ubuntu-arm64-libcxx-Yes	98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andreasfertig]

Hello @Freed-Wu,

what is the motivation for that change? The whole point here is that one has not to say whether the build is inside the Clang source tree or not. Am I overlooking something?

Andreas

[Freed-Wu]

I hope I can build the project by cmake's FetchContent(), However CMAKE_CURRENT_SOURCE_DIR != CMAKE_SOURCE_DIR set BUILD_INSIGHTS_OUTSIDE_LLVM=ON make it impossible.

[Freed-Wu]

For example, https://github.com/Freed-Wu/cppinsights.nvim use git submodule to get the source code, not cmake's FetchContent().