Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all options to def file #668

Closed
wants to merge 1 commit into from
Closed

Conversation

Freed-Wu
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (751c3d9) to head (ad41f01).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   98.00%   98.13%   +0.12%     
==========================================
  Files          20       19       -1     
  Lines        6527     5474    -1053     
==========================================
- Hits         6397     5372    -1025     
+ Misses        130      102      -28     
Flag Coverage Δ
insights-macos ?
insights-ubuntu-amd64-libcxx-No 98.08% <100.00%> (-0.21%) ⬇️
insights-ubuntu-amd64-libcxx-Yes 98.06% <100.00%> (-0.21%) ⬇️
insights-ubuntu-arm64-libcxx-No 98.04% <100.00%> (-0.21%) ⬇️
insights-ubuntu-arm64-libcxx-Yes 98.02% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasfertig
Copy link
Owner

Hello @Freed-Wu,

there are two reasons why they were not part of the def file.

  1. They are only used within Insights.cpp.
  2. All the options that are in the def file should generate a help page, which will end up here: https://docs.cppinsights.io/command_line_options.html.
    These tests make this PR fail. The tests also assume that it is a transformation-related option.

I'm not sure whether moving them would be beneficial.

Andreas

@Freed-Wu
Copy link
Contributor Author

Sounds reasonable.

@Freed-Wu Freed-Wu closed this Sep 21, 2024
@Freed-Wu Freed-Wu deleted the opt branch September 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants