requirements.txt #529
requirements.txt #529
Conversation
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 41.64% 41.05% -0.60%
==========================================
Files 152 156 +4
Lines 15304 15555 +251
==========================================
+ Hits 6374 6386 +12
- Misses 8930 9169 +239
Continue to review full report at Codecov.
|
|
Are all of these are needed when you |
requirements.txt
Outdated
| requests | ||
| scikit-image | ||
| scikit-learn | ||
| scipy |
There was a problem hiding this comment.
It's used in the images_batch.py.
All the functions from scipy.ndimage are bounded to the ImagesBatch methods via @add_methods decorator.
Moreover, skimage.transform.resize method added through the same decorator, which implies additional dependency. The same resize method already explicitly implemented in the class. So I suggest removing one added via decorator(the same for np.pad method)
P.S. I do not succeed in launching any of these methods and did not find examples how to.
| .. note:: | ||
|
|
||
| This requires torch | ||
| .. automodule:: batchflow.models.torch |
There was a problem hiding this comment.
automodule is not a good idea as it will include everything public in an inconvenient order
There was a problem hiding this comment.
According to the docs it will insert only the docstring of the object by default
docs/index.rst
Outdated
| * numba | ||
| * pandas | ||
| * psutil | ||
| * scipy |
There was a problem hiding this comment.
Where do we need scipy? in samplers only? Import it only when really needed.
There was a problem hiding this comment.
Scipy is also needed for instance segmentation utility function get_components .
The metrics module are being imported in pipeline.py.
We can exclude utils functions from metrics.__init__.py and it will be fine. Or make the scipy import optional there.
Co-authored-by: Roman Kh <[email protected]>
Co-authored-by: Roman Kh <[email protected]>
|
Please, resolve the conflict and update reqs in accordance with latest pull requests |
This PR updates
requirements.txt, adds the corresponding section to the documentation, and makes some imports optional.