Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC (especially DMM plugin) should identify devices by ID and not by name #335

Open
dNechita opened this issue Jun 22, 2021 · 3 comments
Open
Assignees
Labels

Comments

@dNechita
Copy link
Contributor

There are situations where multiple IIO devices with the same name exists and in those cases there is no way to differentiate the devices if looking them up by name.

@dNechita dNechita added the bug label Jun 22, 2021
@dNechita dNechita self-assigned this Jun 22, 2021
@nunojsa
Copy link
Contributor

nunojsa commented Jun 22, 2021

In theory this is the first thing to try iio_device_get_label()... in the kernel, IIO labels are how devices should be distinguished when multiple devices exist. We were doing this by setting the device name with the devicetree node name which is not how things should be done in IIO. Now that libiio supports labels, we can start doing this properly (in new drivers)... In #323 , I'm already making use of them :). Unfortunately for 2019_R2 we cannot use it as we cannot assume that 2019_R2 libiio has support for it

@rgetz
Copy link
Contributor

rgetz commented Aug 25, 2021

yeah, I would agree - by label, by name (if no duplicates), and by ID as the last resort...

@nunojsa
Copy link
Contributor

nunojsa commented Aug 26, 2021

I have started to do it with #345. Maybe the DMM plugin is the next on the list...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants