Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table cell colors #361

Open
amyjko opened this issue Nov 27, 2023 · 2 comments
Open

Table cell colors #361

amyjko opened this issue Nov 27, 2023 · 2 comments
Assignees
Labels
feature Something new Bookish could do reading Related to reading books. writing Related to book authoring.

Comments

@amyjko
Copy link
Owner

amyjko commented Nov 27, 2023

What's the problem?

Some authors would like to use colors on table cells, rows, and columns in order to highlight things.

What's the design idea?

This is complex from a themeing perspective, if we want to keep things accessible and simple. For example, we could allow for arbitrary colors to be set on cell backgrounds, but then we'd need to allow text color to be set arbitrarily, to ensure readability. So we could define some highlight color in the theme (or reuse the one we have) and then allow cells to be highlighted. Or we could allow arbitrary colors, then compute a color from that color for the text.

The other challenge is that color information needs to be communicated some other way to screen readers.

Who benefits?

Anyone who wants to compute information through color.

@amyjko amyjko added writing Related to book authoring. reading Related to reading books. feature Something new Bookish could do labels Nov 27, 2023
@amyjko amyjko self-assigned this Nov 27, 2023
@orcmid
Copy link

orcmid commented Nov 27, 2023

In the past I have run across information about how to do that while preserving accessibility. There are apparently pairs that tend to be best in case of color-blindness. I'm certain there's advice about it somewhere.

Good question about screen readers too.

@amyjko
Copy link
Owner Author

amyjko commented Nov 27, 2023

Yes, there's plenty of guidance on choosing colors; that's not the hard part. The hard part is designing a feature that communicates color information to people relying on screen readers; e.g. making a cell red to communicate "badness", for example, not only has culturally situated meaning, but screen readers essentially ignore the color. There's also no good way of converting colors to descriptions of colors. So adding a feature like this opens the door to exclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something new Bookish could do reading Related to reading books. writing Related to book authoring.
Projects
None yet
Development

No branches or pull requests

2 participants