Prevent saveHTML from munging amp-mustache curly braces via URL-encoding #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Yes, this is yet something else that could be part of |
ThierryA
approved these changes
Jan 26, 2018
| @@ -285,6 +333,14 @@ public static function get_content_from_dom_node( $dom, $node ) { | |||
|
|
|||
| $html = self::restore_amp_bind_attributes( $html ); | |||
|
|
|||
| // Restore amp-mustache placeholders which were replaced to prevent URL-encoded corruption by saveHTML. | |||
There was a problem hiding this comment.
Perhaps something like the prototype replacement below would have been sufficient:
$html = preg_replace_callback(
"#href=[\"|'](%7B.*%7D)?[\"|']+#",
function( $matches ) {
return urldecode( $matches[0] );
},
$html
);If that works for you, it can be updated in another PR.
There was a problem hiding this comment.
I didn't want to do replacements on encodings that were original. And I wanted to limit the replacements to braces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #871. URL-encoding of braces in
hrefattributes is a side effect of switching fromsaveXMLtosaveHTMLin #891.