-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for users to chose AMP + Stories, AMP-only, Stories-only #2470
Comments
I know for WordPress users this would be extremely useful both for individuals and agencies. There are many, many use cases for Stories that will not want to use AMP and that will not be able to manage it, but they do want to own and publish Stories The WordPress Way. Being able to enable or change "Operational Mode" to includes AMP as well as Stories at a later date by toggling to dual |
I'm not sure how these options should be laid out. One option would be to add a “Stories Only” selection after “Reader”: Upon selecting “Stories Only” this could hide the settings not relevant to Stories: One reason I don't like this is I can see Stories twice, and only one of them has the full explanation of what Stories are. Another option would be to have another set of Radio buttons at the top for AMP Site, AMP Stories, or AMP Site+Stories before the template modes. I'm not sure how best to present that either. |
Here's what it could look like to have the second set of radio buttons: If the select “Stories” then the other sections would be hidden: There would also need to be a Stories-specific section for specifying the base URL for the export; this section would be displayed when “Pages + Stories” or “Stories” is selected. |
Strong +1 for the second option with a few suggestions. Checkboxes would make more sense than radio options in this case and I would suggest to follow amp.dev terminologies. That would give us something like: AMP Formats
Both checkboxes should probably have a description too. IMO both should be enabled by default. |
My first thought was also checkboxes. And Formats definitely sounds better than Operational Mode.
For new installs that makes sense, for updates it might be a bit confusing for users. |
I don't think checkboxes make sense, since at least one has to be selected. |
At least, if checkboxes were done then client-side validation logic would need to be put in place to make sure that at least one is selected. Good point on aligning the format labels with what is used on amp.dev |
The second option LGTM; we can iterate on it, but that serves the intended purpose to start with. I think checkboxes should not be used here. Let's follow the approach of the template modes. |
+1 also for aligning with AMP.dev, but removing redundancy on the
|
Here are the two alternatives I see. In both cases, I think “Template Mode” should be renamed to “Website Mode”, since this is only relevant to the Website experience. I also think “Operational Mode” section would be better termed “Experiences” since this is what amp.dev calls the different formats. Also, instead of “Websites” I think it should be just ”Website” since the context is a single WordPress install. “Stories” still works because multiple stories would be published on the WordPress install. Now as for selecting the desired experiences: Radio Buttons
Checkboxes
|
The checkboxes look cleaner indeed. And your suggestion about validation makes sense; is indeed a little weird (from an expectation perspective) but that is balanced by the gain in conciseness and clarity. The case with Radial buttons would look better if laid out in the order:
And put the explanation used for the case of the checkboxes. The last item (Website and Stories) would not need an explanation. I am feeling inclined towards the checkboxes. +1 on using Q: The |
Already mentioned it but strong +1 for checkboxes + validation. Having 3rd format would illustrate that radios aren't suitable/scalable even further as we would have to have all the radios below to cover all possible cases:
|
Regarding naming convention, "AMP Formats" seems to be what is/will be used so I would vote to use that in the plugin too (ie not Experiences). |
I am wary of calling AMP for Websites a format. Such terminology contributes to the misconceptions about AMP. AMP is not a format; it is a web components library. |
With radio buttons users know they can only choose one "mode of operations" so radio buttons is the choice we would typically recommend. With checkboxes users typically know they can check more than one. If users choose one radio for the top section and one from the bottom sections - add a separation line between the two sections and use radio buttons so they know what options they are choosing from and that there are two sections to complete. possibly.... |
You must "select at least one".... you can "only select one" right? |
No, you can select both. Either you want to use AMP for Websites, AMP for Stories, or both at the same time. |
I understood you had to choose one of the 3 options. |
With checkboxes there are only two, and you have to chose one or both. If you select none, then the user should just deactivate the AMP plugin because it wouldn't do anything. |
Ok you CAN choose both - thanks for explaining. checkboxes makes sense then. |
@amedina thoughts on the description with the Website experience:
I lifted it from https://amp.dev/about/websites |
AMP is a powerful web components framework which allows you to ensure your website is fast, user-first, and monetizes well. AMP puts at your fingertips tons of advanced capabilities effectively reducing the operating and development costs of your sites. Read more about AMP Websites. |
* Always allow switching from Transitional to Native on sites that are defined with `add_theme_support('amp', ['paired' => true])`. Fixes #2312. * Restore suppression of validation error warnings appearing in Reader mode. Fixes #2311 * Add functionality for users to chose AMP + Stories, AMP-only, Stories-only. Fixes #2470 * Phase out “Native” terminology in favor of “AMP-first”. Fixes #2507.
Testing instructions In WordPress admin, go to AMP -> General and test the following things:
Next up:
Last but not least:
|
Verified in QA |
As long as the Stories editor is part of the AMP Plugin, it needs to provide the controls for users to chose how the plugin would be used. The options could include these (or a variation):
AMP + Stories
: Serve AMP content, and enable StoriesAMP Only
: Use AMP only, hide Stories editorStories Only
: Only use the Stories feature, do not serve AMP pagesOne possibility (discussed with @westonruter) could be to add a new "Operational Mode" complementing the Native, Transitional, Reader trifecta, with a "Stories" mode. The user could check only the Stories checkbox (Stories only), or check the Stories checkbox and one of the AMP template modes (Stories + AMP).
The text was updated successfully, but these errors were encountered: