Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue with Exec API #168

Open
amihaiemil opened this issue Nov 4, 2018 · 6 comments
Open

Continue with Exec API #168

amihaiemil opened this issue Nov 4, 2018 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed role/DEV scope

Comments

@amihaiemil
Copy link
Owner

amihaiemil commented Nov 4, 2018

Let's continue with it. API is described here.

See contributing guidelines. Also, this might be helpful.

@amihaiemil amihaiemil added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 4, 2018
@amihaiemil amihaiemil added the bug Something isn't working label Feb 16, 2020
@0crat
Copy link
Collaborator

0crat commented Feb 16, 2020

Bug was reported, see §29: +15 point(s) just awarded to @amihaiemil/z

@edanilenko
Copy link

The main problem is the exec command is a part of container, and the start command is a part of common docker api.

You should send POST request to /containers/{containerId}/exec for creating exec instance, then send POST to /exec/{execId}/start for starting.

So u should pass to RtContainer command and env arguments, then pass the execution id to RtDocker instance to invoke start, inspect, resize methods.

@amihaiemil
Copy link
Owner Author

@edanilenko It's not that complicated, don't worry. I'll implement the Execs.getExec(...) and RtExec, then it will be clear :D

@amihaiemil
Copy link
Owner Author

amihaiemil commented Apr 16, 2020

@edanilenko See how RtExec is implemented. It still needs two more methods: start and resize.

You can create an Exec via the Exec :: container.exec(...) method. This method will make the HTTP Call to create the exec and then will return this.docker.execs().get(ID).

Makes sense? :D

@lumimul
Copy link

lumimul commented Apr 22, 2020

some problem with implementation of start method
how it will work if we need interactive mode?

@amihaiemil
Copy link
Owner Author

@lumimul That's a good question... I'll look over it and try to think of something.
If you have any ideas, I'm open for suggestions :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed role/DEV scope
Projects
None yet
Development

No branches or pull requests

4 participants