From 1da13d39757215e55f44b28ced88d74b06e70283 Mon Sep 17 00:00:00 2001
From: Reto Kromer <retokromer@users.noreply.github.com>
Date: Sat, 18 Feb 2017 15:24:38 +0100
Subject: [PATCH] unifying

- for readability and maintenance use `cat` instead of multiple `echo`
- similar variable order through the scripts
- set version to 0.9
---
 lto2filemaker | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/lto2filemaker b/lto2filemaker
index 6718519..4e3cb57 100755
--- a/lto2filemaker
+++ b/lto2filemaker
@@ -5,34 +5,32 @@
 # Server using two tables called "lto_tapes" and "lto_files" with fields
 # according to the LTFS XML format.
 
-VERSION=0.1
+VERSION="0.9"
+SCRIPTDIR=$(dirname "${0}")
 REQUIRECONFIG="Y"
 DEPENDENCIES=(xml curl)
 unset CURL_OPTS
 VERBOSITY=0
-SCRIPTDIR=$(dirname "${0}")
 
 . "${SCRIPTDIR}/mmfunctions" || { echo "Missing '${SCRIPTDIR}/mmfunctions'. Exiting." ; exit 1 ; }
 
 _usage(){
-    echo
-    echo "$(basename "${0}") ${VERSION}"
-    echo "This application will create a file suitable for broadcast or editing"
-    echo "from a video file or package input with the following options."
-    echo "Dependencies: ${DEPENDENCIES[@]}"
-    echo "Usage: $(basename "${0}") [-v|-h] LTFS_SCHEMA_FILE"
-    echo "  -v N  verbosity, 0 hides curl errors, default is 0"
-    echo "  -h    display this help"
-    echo
-    exit
-}
+cat <<EOF
+$(basename "${0}") ${VERSION}
+This application will create a file suitable for broadcast or editing
+from a video file or package input with the following options.
+Dependencies: ${DEPENDENCIES[@]}
+Usage: $(basename "${0}") [-v | -h] LTFS_SCHEMA_FILE
+  -v N  verbosity, 0 hides curl errors, default is 0
+  -h    display this help
+EOF}
 [ "${#}" = 0 ] && _usage
 
 OPTIND=1
 while getopts ":v:h" opt ; do
     case "${opt}" in
         v) VERBOSITY="${OPTARG}" ;;
-        h) _usage ;;
+        h) _usage ; exit 0 ;;
         :) echo "Error: Option -$OPTARG requires an argument" ; exit 1 ;;
         *) echo "Error: Bad option -$OPTARG" ; _usage ; exit 1 ;;
     esac