From a68755ee4f65061cef7f632115fb36bf15888603 Mon Sep 17 00:00:00 2001
From: Philipp Rumpf <philipp.rumpf@uni-bamberg.de>
Date: Thu, 16 Nov 2023 14:15:32 +0000
Subject: [PATCH] CrossRefImportMetadataSourceServiceIT: Test empty responses
 don't result in ... results.

---
 .../CrossRefImportMetadataSourceServiceIT.java | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/dspace-server-webapp/src/test/java/org/dspace/app/rest/CrossRefImportMetadataSourceServiceIT.java b/dspace-server-webapp/src/test/java/org/dspace/app/rest/CrossRefImportMetadataSourceServiceIT.java
index 72524709ec6..31c22692f00 100644
--- a/dspace-server-webapp/src/test/java/org/dspace/app/rest/CrossRefImportMetadataSourceServiceIT.java
+++ b/dspace-server-webapp/src/test/java/org/dspace/app/rest/CrossRefImportMetadataSourceServiceIT.java
@@ -48,6 +48,24 @@ public class CrossRefImportMetadataSourceServiceIT extends AbstractLiveImportInt
     @Autowired
     private CrossRefImportMetadataSourceServiceImpl crossRefServiceImpl;
 
+    @Test
+    public void crossRefImportMetadataGetNoRecordsTest() throws Exception {
+        context.turnOffAuthorisationSystem();
+        CloseableHttpClient originalHttpClient = liveImportClientImpl.getHttpClient();
+        CloseableHttpClient httpClient = Mockito.mock(CloseableHttpClient.class);
+        try {
+            liveImportClientImpl.setHttpClient(httpClient);
+            CloseableHttpResponse response = mockResponse("" , 404, "Not Found");
+            when(httpClient.execute(ArgumentMatchers.any())).thenReturn(response);
+
+            context.restoreAuthSystemState();
+            Collection<ImportRecord> recordsImported = crossRefServiceImpl.getRecords("test query", 0, 2);
+            assertEquals(0, recordsImported.size());
+        } finally {
+            liveImportClientImpl.setHttpClient(originalHttpClient);
+        }
+    }
+
     @Test
     public void crossRefImportMetadataGetRecordsTest() throws Exception {
         context.turnOffAuthorisationSystem();