Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor conformance dsl to eliminate PartialEq use. #839

Open
nirosys opened this issue Sep 30, 2024 · 0 comments
Open

Refactor conformance dsl to eliminate PartialEq use. #839

nirosys opened this issue Sep 30, 2024 · 0 comments
Assignees

Comments

@nirosys
Copy link
Contributor

nirosys commented Sep 30, 2024

Related: #833

The dsl implementation was originally implemented using PartialEq to compare LazyValues and ProxyElement/Element, which resulted in a few places where reading data out of either could result in an error, which could not be bubbled up due to the PartialEq interface. This code needs to be reworked in order to simplify the equality tests, and allow errors to be bubbled up correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant