Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate dom.Symbol extending String directly #574

Open
zslayton opened this issue Mar 5, 2020 · 0 comments
Open

Re-evaluate dom.Symbol extending String directly #574

zslayton opened this issue Mar 5, 2020 · 0 comments

Comments

@zslayton
Copy link
Contributor

zslayton commented Mar 5, 2020

dom.Symbol extends Javascript's built-in String class because we do not currently have a SymbolToken entity. (This is in part because when reading a symbol the Reader interface doesn't expose the underlying symbol ID.)

If we decide to have dom.Symbol extend a future SymbolToken class, we should also consider having SymbolToken extend String to minimize API breakage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zslayton