Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cool project, but what licence for it? #1

Open
Ivony opened this issue Jan 29, 2016 · 6 comments
Open

cool project, but what licence for it? #1

Ivony opened this issue Jan 29, 2016 · 6 comments

Comments

@Ivony
Copy link

Ivony commented Jan 29, 2016

I'm forked this project to make a css sprite generator.

can I do this?

what licence applied for this project?

@am11
Copy link
Owner

am11 commented Jan 29, 2016

Thanks. Actually this work was done for madskristensen/WebEssentials2013#466.

I have updated the Nuget package link, license (http://www.codeproject.com/info/cpol10.aspx) and credit to the original author @mperdeck, in the Readme. I just upgraded this project for .NET4.

The comments on the CodeProject Article; http://www.codeproject.com/Articles/210979/F, suggest some performance improvements which can be incorporated for vNext. :)

@Ivony
Copy link
Author

Ivony commented Jan 30, 2016

thanks a lot.

the feature dose contain in Web Essentials 2013,
but, it's removed in Web Essentials 2015.

and we need a simple tools to auto generate sprite image in building process without Visual Studio.

I forked this project, and add an console project to generate sprite image.

thanks for your works, again, it's so cool and helpful.

@am11
Copy link
Owner

am11 commented Jan 30, 2016

Hello, although we implemented sprite generator in WE using RectanglePacker, but that was changed subsequently with a very basic implementation with option to set the horizontal/vertical direction. The cool thing about the feature was the .sprite file, the XML format for configuration with dimensions for every constituent image and the fact that WE2013 generates three samples: .css, .less and .scss.

As WE2015 has stripped away many features, most of them are ported to WebCompiler: https://github.com/madskristensen/WebCompiler.. except for sprite :-(

We can probably open an issue or send a pull request to WebCompiler and port this feature from WE2013. Alternatively, we can implement that functionality in this package to generate .sprite, a sample .css, less and .scss files. Another thing that can be done is to support the WE2013 sprite format, with additional option to let user control the RectanglePacker's heuristic algorithm's fuzziness; which comes at the cost of performance; the more time spared to run it, the better results it yields (aka NP-hard problem aka rectangle packing)! :)

@mperdeck
Copy link

@Ivony I'm happy for you to use it, provided that

  • you acknowledge that my work may not be fit for purpose - that is, if it doesn't work and you lose money as a result of this, you won't sue me :-)
  • you credit my work somehow (for example in your documentation).

The license would be CPOL.

@mperdeck
Copy link

@am11 I'm honored that you suggested RectanglePacker for use in a Microsoft product.

Do you know if it was ever used in a live product? If it was, I'll update my resume (makes me a bit more employable).

For what it's worth (it's now a few years old), I actually used it in a product that generates sprites on the fly:
http://www.codeproject.com/Articles/235646/Package-that-reduces-page-load-times-by-compressin

@am11
Copy link
Owner

am11 commented Jan 31, 2016

@mperdeck, thanks for sharing the link. Regarding the package usage, after incorporating this feature (madskristensen/WebEssentials2013#472), it was decided to use the basic horizontal/vertical directional stitching of images, the decision which I opposed, but still the subsequent release didn't packaged RectanglePacker:
https://github.com/madskristensen/WebEssentials2013/releases/tag/v1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants