-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show/file overwriting issue. #3
Comments
i will not lie to you |
Not a problem, the only shows it might effect right now are YU-NO: A girl who chants love at the bound of this world and possibly Bungo Stray Dogs and possibly Mob Psycho depending on who is handling the dub for streaming. But it might be an issue if Funimation and Crunchy are going to start sharing more shows this season and in the future again. https://www.crunchyroll.com/yu-no-a-girl-who-chants-love-at-the-bound-of-this-world https://www.crunchyroll.com/bungo-stray-dogs https://www.crunchyroll.com/mob-psycho-100 |
* fix update problem * add code so that video with identical names dont overwrite each other
i updated the code |
What was changed? Autocatch did not pick up the dub link for https://www.crunchyroll.com/yu-no-a-girl-who-chants-love-at-the-bound-of-this-world. Is there a way to have it pick like if you want only want the Spanish dub for a series that has more than one language like Mob Mob Psycho 100? Had to download https://www.crunchyroll.com/yu-no-a-girl-who-chants-love-at-the-bound-of-this-world/episode-1-you-know-783344 by it self but it still named the file the same as the Japanese one when the title is YU-NO: A Girl Who Chants Love at the Bound of This World (Dub) Episode 1 – You Know? |
the code in catching link ignore any list has dub in it |
That could be an issue still as some use Dubbed also or English Dub unless you added in the variations. |
lol sorry i meant they filter dubed links out |
https://www.crunchyroll.com/search?from=&q=English+Dub You can see here they use all kinds of different variations on it depending on the publisher. |
ik |
Because like on this one Aniplex had added subbed and dubbed for each one too. https://www.crunchyroll.com/rurouni-kenshin They need a set standard because it is a total mess looking for shows by filter on their site. https://www.crunchyroll.com/fist-of-the-north-star-the-movie |
Would it be possible to have it like how you can pick a sub language in the settings but for the different audio languages in the settings? |
For now I will make it only only subed or with dub linked |
first off all sorry for the delay |
@darkhelmet2016 |
Ok, but by dub filter meant more along the lines like having it where you could pick like the Spanish or German dub by itself like you can change the sub option for what subs you want as your primary and fall back. 'Set this to the desired subtitle language. If the subtitles aren't available in that language, it reverts to the second language option (below). 'And make one similar but for the audio when there are more than one on a show page. |
This is the source page from https://www.crunchyroll.com/mob-psycho-100 that has more than one language in it. view-source:https://www.crunchyroll.com/mob-psycho-100 |
lol i said this what it will look like |
did you try 1.4? |
It will overwrite files if there is an uncensored version like ://www.crunchyroll.com/senran-kagura-shinovi-master, some shows have multiple versions for cut/uncut or if it has more than one dub like Spanish or Russian. https://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world. But one problem is between different publishers they use tags for Dub or sub shows and some use Dub, English Dub or other variations and the program will overwrite them if they do not specify between the different languages or tags like on Shinovi Master. Crunchy has recently started dubbing shows in multiple languages so this might be an issue when batch downloading.
The text was updated successfully, but these errors were encountered: