Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/file overwriting issue. #3

Open
darkhelmet2016 opened this issue Apr 20, 2019 · 18 comments
Open

Show/file overwriting issue. #3

darkhelmet2016 opened this issue Apr 20, 2019 · 18 comments
Labels
enhancement New feature or request

Comments

@darkhelmet2016
Copy link

It will overwrite files if there is an uncensored version like ://www.crunchyroll.com/senran-kagura-shinovi-master, some shows have multiple versions for cut/uncut or if it has more than one dub like Spanish or Russian. https://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world. But one problem is between different publishers they use tags for Dub or sub shows and some use Dub, English Dub or other variations and the program will overwrite them if they do not specify between the different languages or tags like on Shinovi Master. Crunchy has recently started dubbing shows in multiple languages so this might be an issue when batch downloading.

@alzamer2 alzamer2 added the enhancement New feature or request label Apr 20, 2019
@alzamer2
Copy link
Owner

i will not lie to you
i added new option to the code that let you update the code
so i'm burnt out atm
will takle this issue later

@darkhelmet2016
Copy link
Author

darkhelmet2016 commented Apr 20, 2019

Not a problem, the only shows it might effect right now are YU-NO: A girl who chants love at the bound of this world and possibly Bungo Stray Dogs and possibly Mob Psycho depending on who is handling the dub for streaming. But it might be an issue if Funimation and Crunchy are going to start sharing more shows this season and in the future again. https://www.crunchyroll.com/yu-no-a-girl-who-chants-love-at-the-bound-of-this-world https://www.crunchyroll.com/bungo-stray-dogs https://www.crunchyroll.com/mob-psycho-100

alzamer2 referenced this issue Apr 22, 2019
* fix update problem
* add code so that video with identical names dont overwrite each other
@alzamer2
Copy link
Owner

i updated the code
can you test it out?

@darkhelmet2016
Copy link
Author

darkhelmet2016 commented Apr 22, 2019

What was changed? Autocatch did not pick up the dub link for https://www.crunchyroll.com/yu-no-a-girl-who-chants-love-at-the-bound-of-this-world. Is there a way to have it pick like if you want only want the Spanish dub for a series that has more than one language like Mob Mob Psycho 100?

Had to download https://www.crunchyroll.com/yu-no-a-girl-who-chants-love-at-the-bound-of-this-world/episode-1-you-know-783344 by it self but it still named the file the same as the Japanese one when the title is YU-NO: A Girl Who Chants Love at the Bound of This World (Dub) Episode 1 – You Know?
.

@alzamer2
Copy link
Owner

the code in catching link ignore any list has dub in it
what i did is making the code not overwrite finished video, so you can if the video has un cut version
i will add option later so when catching it will catch all links or only english links

@darkhelmet2016
Copy link
Author

That could be an issue still as some use Dubbed also or English Dub unless you added in the variations.

@alzamer2
Copy link
Owner

lol sorry i meant they filter dubed links out

@darkhelmet2016
Copy link
Author

https://www.crunchyroll.com/search?from=&q=English+Dub You can see here they use all kinds of different variations on it depending on the publisher.

@alzamer2
Copy link
Owner

ik

@darkhelmet2016
Copy link
Author

darkhelmet2016 commented Apr 22, 2019

Because like on this one Aniplex had added subbed and dubbed for each one too. https://www.crunchyroll.com/rurouni-kenshin They need a set standard because it is a total mess looking for shows by filter on their site. https://www.crunchyroll.com/fist-of-the-north-star-the-movie

@darkhelmet2016
Copy link
Author

Would it be possible to have it like how you can pick a sub language in the settings but for the different audio languages in the settings?

@alzamer2
Copy link
Owner

For now I will make it only only subed or with dub linked
I need to check many series pages to work out code that look for certain dub language

@alzamer2
Copy link
Owner

first off all sorry for the delay
second, i updated the code
can you try it out?

@alzamer2
Copy link
Owner

@darkhelmet2016
the dub filter is in setting make sure to false it as it set as true in defult
and you may need to delete the settings,ini file

@darkhelmet2016
Copy link
Author

darkhelmet2016 commented Apr 26, 2019

Ok, but by dub filter meant more along the lines like having it where you could pick like the Spanish or German dub by itself like you can change the sub option for what subs you want as your primary and fall back. 'Set this to the desired subtitle language. If the subtitles aren't available in that language, it reverts to the second language option (below). 'And make one similar but for the audio when there are more than one on a show page.

@darkhelmet2016
Copy link
Author

This is the source page from https://www.crunchyroll.com/mob-psycho-100 that has more than one language in it. view-source:https://www.crunchyroll.com/mob-psycho-100

@alzamer2
Copy link
Owner

lol i said this what it will look like
i will work about it

@alzamer2
Copy link
Owner

alzamer2 commented Jan 5, 2021

did you try 1.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants