Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for IResultBase: Make Errors/Successes as IReadOnlyCollection #197

Open
antoineatstariongroup opened this issue Jan 5, 2024 · 1 comment
Labels

Comments

@antoineatstariongroup
Copy link

Since the Errors and Successes collection are just subset of the Reasons collection, it would be better to set those properties as IReadOnlyCollection. It would prevent to try to add/modify the Reasons collection via the Errors/Successes collection

@altmann
Copy link
Owner

altmann commented Jun 19, 2024

Thank your for your feedback. I know what you mean. This change would cause breaking changes in the public api of FluentResults. I made breaking changes like these only in mayor version. I will keep this issue open until I make the next major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants