Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for missing values in diagnostics #26

Open
Seth-Rothschild opened this issue Sep 13, 2018 · 0 comments
Open

Add test for missing values in diagnostics #26

Seth-Rothschild opened this issue Sep 13, 2018 · 0 comments
Labels
easyfix This is a problem but is painless to fix good first issue Good for newcomers

Comments

@Seth-Rothschild
Copy link
Contributor

  • Henchman version: 0.0.3

Description

The following lines loops are not run during tests

  • if duplicates.shape[0] > 0: (line 59)
  • if datacol.isnull().sum() > 0
    • Line 136 for the object column summary
    • Line 161 for boolean
    • Line 177 for numeric
@Seth-Rothschild Seth-Rothschild added good first issue Good for newcomers easyfix This is a problem but is painless to fix labels Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easyfix This is a problem but is painless to fix good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Seth-Rothschild