Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The App's <iframe> extends beyond the window #14

Open
pillowfication opened this issue Aug 16, 2023 · 0 comments
Open

The App's <iframe> extends beyond the window #14

pillowfication opened this issue Aug 16, 2023 · 0 comments

Comments

@pillowfication
Copy link

pillowfication commented Aug 16, 2023

The <iframe> that the child app lives in has its height set to 100% which causes the "Tool Name (1)" header to push it offscreen, which is annoying when developing a plugin that normally extends beyond the vertical space. Could be fixed by using flex to fill the remaining space.

<Grid container direction="column" item xs="auto" className={...}>
  <Box m={4}>
    <Grid container alignItems="center">
      <Grid item xs><Typography variant="overline">Tool Name (1)</Typography></Grid>
      <Grid item><IconButton onClick={this.toggleToolDrawer}>...</IconButton></Grid>
    </Grid>
  </Box>
  <Divider />
  <Grid item xs>
    <iframe style={{ border: 0, height: '100%', width: '100%' }} {...} />
  </Grid>
</Grid>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant