Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viewport coordinate system #5

Open
iangilman opened this issue Sep 19, 2017 · 0 comments
Open

Use viewport coordinate system #5

iangilman opened this issue Sep 19, 2017 · 0 comments

Comments

@iangilman
Copy link
Contributor

iangilman commented Sep 19, 2017

(This is pretty much just a copy of altert/OpenseadragonFabricjsOverlay#18)

It appears that this plugin is using the image coordinate system for the first image in the collection. For multi-image, this can be problematic. I recommend standardizing on the viewport coordinate system instead. I suppose you could have a flag for backwards compatibility.

Also it's probably good to document which coordinate system the canvas overlay is using, regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant