-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also search for ucm2/conf.d/[${CardDriver}|${KernelDriver}]/${CardName}.conf #374
base: master
Are you sure you want to change the base?
Conversation
…e}.conf The CardLongName may be derived from various DMI properties of the system, that have little to do with the card itself. Sometimes, that may be a good thing, but sometimes, it may contain the completely generic "Unknown-UnknownProduct-", see https://gitlab.com/postmarketOS/pmaports/-/issues/1498#note_1716959721 for example. At least for devices using device tree and simple-card, the name of the card (CardName), which then comes from the device tree, which can be provided by the kernel too, may be a lot more relevant, and does actually identify the device. Signed-off-by: Daniel Abrecht <[email protected]>
Why the simple-card driver does not set the CardLongName (GUI string) from DT, too? The DMI fallback for card's long name is there just for ASoC laziness. EDIT: Also, UCM has other way to fetch the DMI info ( |
I don't think the simple-card driver can set the CardLongName from the DT right now. It would have to set Shall I send a patch for that? |
If you look to conf.d/simple-card there is Another option is to create |
I think So, the circumstances in which this works are probably going to be about the same as for the pinephone-pro. For distros where the kernel is loaded directly by uboot without EFI, there will be no DMI, and the It seams there is also a blacklist of invalid DMI names in the kernel, I'll add I will also look into doing the matching in |
The CardLongName may be derived from various DMI properties of the system, that have little to do with the card itself. Sometimes, that may be a good thing, but sometimes, it may contain the completely generic "Unknown-UnknownProduct-", see https://gitlab.com/postmarketOS/pmaports/-/issues/1498#note_1716959721 for example. At least for devices using device tree and simple-card, the name of the card (CardName), which then comes from the device tree, which can be provided by the kernel too, may be a lot more relevant, and does actually identify the device.