Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Help" links missing/inconsistent #151

Closed
njnatale-lm opened this issue Oct 24, 2022 · 2 comments
Closed

"Help" links missing/inconsistent #151

njnatale-lm opened this issue Oct 24, 2022 · 2 comments
Labels

Comments

@njnatale-lm
Copy link

Starts here: https://github.com/AlphaNodes/additionals/blob/main/app/helpers/additionals_menu_helper.rb#L68

    admin_items = [{ title: 'Redmine Changelog',
                     url: "https://www.redmine.org/projects/redmine/wiki/Changelog_#{Redmine::VERSION::MAJOR}_#{Redmine::VERSION::MINOR}",
                     id: :changelog },
                   { title: 'Redmine Upgrade',
                     url: 'https://www.redmine.org/projects/redmine/wiki/RedmineUpgrade',
                     id: :security_advisories },
                   { title: 'Redmine Security Advisories',
                     url: 'https://www.redmine.org/projects/redmine/wiki/Security_Advisories' }]
  • The id for the upgrade link seems to be in the wrong place
  • There's no id for the security advisories link; without this, the menu item does not appear
@alexandermeindl
Copy link
Collaborator

Hi @njnatale-lm,

thanks for pointing this out!

I fixed this in main branch.

@njnatale-lm
Copy link
Author

Thank you, @alexandermeindl - hopefully #152 is just as easy to fix! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants