From 287cd3a2b207bdbdff42fc701b5114343c880739 Mon Sep 17 00:00:00 2001
From: Bruce Bolt <bruce.bolt@digital.cabinet-office.gov.uk>
Date: Mon, 2 Dec 2024 13:22:10 +0000
Subject: [PATCH] Change World Index spec to compare hashes, not JSON string

The world index spec if currently comparing JSON strings, which means
the test has to specify the keys in exactly the same order as they are
included in the JSON.

Additionally, rspec doesn't give a useful diff when this test fails when
comparing JSON strings, like it would with a hash.

Therefore changing this spec to compare hashes, like we are doing in the
other GraphQL integration tests.
---
 spec/integration/graphql/world_index_spec.rb | 40 ++++++++++----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/spec/integration/graphql/world_index_spec.rb b/spec/integration/graphql/world_index_spec.rb
index 58ad5100d..714fecf02 100644
--- a/spec/integration/graphql/world_index_spec.rb
+++ b/spec/integration/graphql/world_index_spec.rb
@@ -64,35 +64,35 @@
       }
 
       expected = {
-        "data": {
-          "edition": {
-            "title": "Help and services around the world",
-            "worldLocations": [
+        data: {
+          edition: {
+            title: "Help and services around the world",
+            worldLocations: [
               {
-                "active": true,
-                "analyticsIdentifier": "WL1",
-                "contentId": "d3b7ba48-5027-4a98-a594-1108d205dc66",
-                "name": "Test World Location",
-                "slug": "test-world-location",
-                "updatedAt": "2024-10-18T14:22:38+01:00",
+                active: true,
+                analyticsIdentifier: "WL1",
+                contentId: "d3b7ba48-5027-4a98-a594-1108d205dc66",
+                name: "Test World Location",
+                slug: "test-world-location",
+                updatedAt: "2024-10-18T14:22:38+01:00",
               },
             ],
-            "internationalDelegations": [
+            internationalDelegations: [
               {
-                "active": false,
-                "analyticsIdentifier": "WL2",
-                "contentId": "f0313f16-e25c-4bfe-a0fc-e561833f705f",
-                "name": "Test International Delegation",
-                "slug": "test-international-delegation",
-                "updatedAt": "2024-10-19T15:07:44+01:00",
+                active: false,
+                analyticsIdentifier: "WL2",
+                contentId: "f0313f16-e25c-4bfe-a0fc-e561833f705f",
+                name: "Test International Delegation",
+                slug: "test-international-delegation",
+                updatedAt: "2024-10-19T15:07:44+01:00",
               },
             ],
           },
-
         },
-      }.to_json
+      }
 
-      expect(response.body).to eq(expected)
+      parsed_response = JSON.parse(response.body).deep_symbolize_keys
+      expect(parsed_response).to eq(expected)
     end
   end
 end