Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue links rather than checks? #58

Open
kevindew opened this issue Apr 13, 2017 · 0 comments
Open

Queue links rather than checks? #58

kevindew opened this issue Apr 13, 2017 · 0 comments

Comments

@kevindew
Copy link
Member

This isn't definitively an issue, more a design choice and probably ties into the solution for #57

Currently we queue checks, but I'd have thought it would make more sense to queue for links and then when the job starts check if there are any pending Checks for a link to decide whether to run. Can complete all the pending checks for a Link in one go.

Could also use sidekiq unique jobs to limit us to queuing once per link and running same link at same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant