Document the database creation/seed steps #764
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to run these steps manually when making Whitehall. I can't find anywhere else where we've documented these steps, and it took me a little while to figure out the `RAILS_ENV` dependency for getting tests working. I did consider documenting this elsewhere (https://docs.publishing.service.gov.uk/manual/conventions-for-rails-applications.html) but given govuk-docker is all about setting up a working local environment, and given govuk-docker handles everything but db creation/seeding for you, then this it seems reasonable to document this gotcha here, where it's more likely to be seen at point of need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLACEHOLDER: this may just have been needed for Whitehall, in which case a tweak to the Whitehall Makefile is probably the solution.
I had to run these steps manually when making Whitehall. I can't find anywhere else where we've documented these steps, and it took me a little while to figure out the
RAILS_ENVdependency for getting tests working.I did consider documenting this elsewhere (https://docs.publishing.service.gov.uk/manual/conventions-for-rails-applications.html) but given govuk-docker is all about setting up a working local environment, and given govuk-docker handles everything but db creation/seeding for you, then this it seems reasonable to document this gotcha here, where it's more likely to be seen at point of need.