From 43780b49de8d9cbc4b371fc63b2ff9afa5c6dea0 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 7 Nov 2023 00:55:53 +0000 Subject: [PATCH 1/2] Bump stylelint-config-gds from 0.3.0 to 1.1.0 Bumps [stylelint-config-gds](https://github.com/alphagov/stylelint-config-gds) from 0.3.0 to 1.1.0. - [Changelog](https://github.com/alphagov/stylelint-config-gds/blob/main/CHANGELOG.md) - [Commits](https://github.com/alphagov/stylelint-config-gds/compare/0.3.0...1.1.0) --- updated-dependencies: - dependency-name: stylelint-config-gds dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- package.json | 2 +- yarn.lock | 84 ++++++++++++++++++++++++++-------------------------- 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/package.json b/package.json index 0173b93b1a..58842ffa21 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,7 @@ "postcss": "^8.4.31", "standardx": "^7.0.0", "stylelint": "^15.11.0", - "stylelint-config-gds": "^0.3.0" + "stylelint-config-gds": "^1.1.0" }, "dependencies": { "@webcomponents/custom-elements": "^1.6.0", diff --git a/yarn.lock b/yarn.lock index c03ff860c7..fbd0c35946 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1695,7 +1695,7 @@ lodash.truncate@^4.4.2: resolved "https://registry.yarnpkg.com/lodash.truncate/-/lodash.truncate-4.4.2.tgz#5a350da0b1113b837ecfffd5812cbe58d6eae193" integrity sha1-WjUNoLERO4N+z//VgSy+WNbq4ZM= -lodash@^4.17.14, lodash@^4.17.19, lodash@^4.17.21: +lodash@^4.17.14, lodash@^4.17.19: version "4.17.21" resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c" integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg== @@ -2238,12 +2238,12 @@ postcss-safe-parser@^6.0.0: resolved "https://registry.yarnpkg.com/postcss-safe-parser/-/postcss-safe-parser-6.0.0.tgz#bb4c29894171a94bc5c996b9a30317ef402adaa1" integrity sha512-FARHN8pwH+WiS2OPCxJI8FuRJpTVnn6ZNFiqAM2aeW2LwTHWWmWgIyKC6cUo0L8aeKiF/14MNvnpls6R2PBeMQ== -postcss-scss@^4.0.2: - version "4.0.3" - resolved "https://registry.yarnpkg.com/postcss-scss/-/postcss-scss-4.0.3.tgz#36c23c19a804274e722e83a54d20b838ab4767ac" - integrity sha512-j4KxzWovfdHsyxwl1BxkUal/O4uirvHgdzMKS1aWJBAV0qh2qj5qAZqpeBfVUYGWv+4iK9Az7SPyZ4fyNju1uA== +postcss-scss@^4.0.9: + version "4.0.9" + resolved "https://registry.yarnpkg.com/postcss-scss/-/postcss-scss-4.0.9.tgz#a03c773cd4c9623cb04ce142a52afcec74806685" + integrity sha512-AjKOeiwAitL/MXxQW2DliT28EKukvvbEWx3LBmJIRN8KfBGZbRTxNYW0kSqi1COiTZ57nZ9NW06S6ux//N1c9A== -postcss-selector-parser@^6.0.13, postcss-selector-parser@^6.0.6: +postcss-selector-parser@^6.0.13: version "6.0.13" resolved "https://registry.yarnpkg.com/postcss-selector-parser/-/postcss-selector-parser-6.0.13.tgz#d05d8d76b1e8e173257ef9d60b706a8e5e99bf1b" integrity sha512-EaV1Gl4mUEV4ddhDnv/xtj7sxwrwxdetHdWUGnT4VJQf+4d05v6lHYZr8N573k5Z0BViss7BDhfWtKS3+sfAqQ== @@ -2251,7 +2251,7 @@ postcss-selector-parser@^6.0.13, postcss-selector-parser@^6.0.6: cssesc "^3.0.0" util-deprecate "^1.0.2" -postcss-value-parser@^4.1.0, postcss-value-parser@^4.2.0: +postcss-value-parser@^4.2.0: version "4.2.0" resolved "https://registry.yarnpkg.com/postcss-value-parser/-/postcss-value-parser-4.2.0.tgz#723c09920836ba6d3e5af019f92bc0971c02e514" integrity sha512-1NNCs6uurfkVbeXG4S8JFT9t19m45ICnif8zWLd5oPSZ50QnwMfK+H3jv408d4jw/7Bttv5axS5IiHoLaVNHeQ== @@ -2790,53 +2790,53 @@ style-search@^0.1.0: resolved "https://registry.yarnpkg.com/style-search/-/style-search-0.1.0.tgz#7958c793e47e32e07d2b5cafe5c0bf8e12e77902" integrity sha1-eVjHk+R+MuB9K1yv5cC/jhLneQI= -stylelint-config-gds@^0.3.0: - version "0.3.0" - resolved "https://registry.yarnpkg.com/stylelint-config-gds/-/stylelint-config-gds-0.3.0.tgz#d4148b3b330de50c279c3b0a84b1fe0b59ef644a" - integrity sha512-mZ0/C2JAneCrMbmBABJGIIczDR/jlacObBggU5j69bMK2TEwp3kwXDd2YZEPmVe1ayIbsZ/HPAV8khK3kfunWw== +stylelint-config-gds@^1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/stylelint-config-gds/-/stylelint-config-gds-1.1.0.tgz#c47db839b37549c49a96fde15011d76440c7e5eb" + integrity sha512-oc9qmd/7HFYIPwyJNusdKT+vxLXECAg9hcv4kIaec/MHz9n1ryf0nzgAhnKkatArxczK00FpoyyRPQwfa6b9eA== dependencies: - stylelint-config-standard "^29.0.0" - stylelint-config-standard-scss "^6.1.0" + stylelint-config-standard "^34.0.0" + stylelint-config-standard-scss "^11.1.0" -stylelint-config-recommended-scss@^8.0.0: - version "8.0.0" - resolved "https://registry.yarnpkg.com/stylelint-config-recommended-scss/-/stylelint-config-recommended-scss-8.0.0.tgz#1c1e93e619fe2275d4c1067928d92e0614f7d64f" - integrity sha512-BxjxEzRaZoQb7Iinc3p92GS6zRdRAkIuEu2ZFLTxJK2e1AIcCb5B5MXY9KOXdGTnYFZ+KKx6R4Fv9zU6CtMYPQ== +stylelint-config-recommended-scss@^13.1.0: + version "13.1.0" + resolved "https://registry.yarnpkg.com/stylelint-config-recommended-scss/-/stylelint-config-recommended-scss-13.1.0.tgz#04e529ae0e9c1abb1e04de79258461c07811876f" + integrity sha512-8L5nDfd+YH6AOoBGKmhH8pLWF1dpfY816JtGMePcBqqSsLU+Ysawx44fQSlMOJ2xTfI9yTGpup5JU77c17w1Ww== dependencies: - postcss-scss "^4.0.2" - stylelint-config-recommended "^9.0.0" - stylelint-scss "^4.0.0" + postcss-scss "^4.0.9" + stylelint-config-recommended "^13.0.0" + stylelint-scss "^5.3.0" -stylelint-config-recommended@^9.0.0: - version "9.0.0" - resolved "https://registry.yarnpkg.com/stylelint-config-recommended/-/stylelint-config-recommended-9.0.0.tgz#1c9e07536a8cd875405f8ecef7314916d94e7e40" - integrity sha512-9YQSrJq4NvvRuTbzDsWX3rrFOzOlYBmZP+o513BJN/yfEmGSr0AxdvrWs0P/ilSpVV/wisamAHu5XSk8Rcf4CQ== +stylelint-config-recommended@^13.0.0: + version "13.0.0" + resolved "https://registry.yarnpkg.com/stylelint-config-recommended/-/stylelint-config-recommended-13.0.0.tgz#c48a358cc46b629ea01f22db60b351f703e00597" + integrity sha512-EH+yRj6h3GAe/fRiyaoO2F9l9Tgg50AOFhaszyfov9v6ayXJ1IkSHwTxd7lB48FmOeSGDPLjatjO11fJpmarkQ== -stylelint-config-standard-scss@^6.1.0: - version "6.1.0" - resolved "https://registry.yarnpkg.com/stylelint-config-standard-scss/-/stylelint-config-standard-scss-6.1.0.tgz#a6cddd2a9430578b92fc89726a59474d5548a444" - integrity sha512-iZ2B5kQT2G3rUzx+437cEpdcnFOQkwnwqXuY8Z0QUwIHQVE8mnYChGAquyKFUKZRZ0pRnrciARlPaR1RBtPb0Q== +stylelint-config-standard-scss@^11.1.0: + version "11.1.0" + resolved "https://registry.yarnpkg.com/stylelint-config-standard-scss/-/stylelint-config-standard-scss-11.1.0.tgz#53c2fb9423ed89c0921aa83479892a912cc1ca15" + integrity sha512-5gnBgeNTgRVdchMwiFQPuBOtj9QefYtfXiddrOMJA2pI22zxt6ddI2s+e5Oh7/6QYl7QLJujGnaUR5YyGq72ow== dependencies: - stylelint-config-recommended-scss "^8.0.0" - stylelint-config-standard "^29.0.0" + stylelint-config-recommended-scss "^13.1.0" + stylelint-config-standard "^34.0.0" -stylelint-config-standard@^29.0.0: - version "29.0.0" - resolved "https://registry.yarnpkg.com/stylelint-config-standard/-/stylelint-config-standard-29.0.0.tgz#4cc0e0f05512a39bb8b8e97853247d3a95d66fa2" - integrity sha512-uy8tZLbfq6ZrXy4JKu3W+7lYLgRQBxYTUUB88vPgQ+ZzAxdrvcaSUW9hOMNLYBnwH+9Kkj19M2DHdZ4gKwI7tg== +stylelint-config-standard@^34.0.0: + version "34.0.0" + resolved "https://registry.yarnpkg.com/stylelint-config-standard/-/stylelint-config-standard-34.0.0.tgz#309f3c48118a02aae262230c174282e40e766cf4" + integrity sha512-u0VSZnVyW9VSryBG2LSO+OQTjN7zF9XJaAJRX/4EwkmU0R2jYwmBSN10acqZisDitS0CLiEiGjX7+Hrq8TAhfQ== dependencies: - stylelint-config-recommended "^9.0.0" + stylelint-config-recommended "^13.0.0" -stylelint-scss@^4.0.0: - version "4.2.0" - resolved "https://registry.yarnpkg.com/stylelint-scss/-/stylelint-scss-4.2.0.tgz#e25fd390ee38a7e89fcfaec2a8f9dce2ec6ddee8" - integrity sha512-HHHMVKJJ5RM9pPIbgJ/XA67h9H0407G68Rm69H4fzFbFkyDMcTV1Byep3qdze5+fJ3c0U7mJrbj6S0Fg072uZA== +stylelint-scss@^5.3.0: + version "5.3.1" + resolved "https://registry.yarnpkg.com/stylelint-scss/-/stylelint-scss-5.3.1.tgz#7f0f5f06d0a2a3c515aa71d3a8de3548045e03e1" + integrity sha512-5I9ZDIm77BZrjOccma5WyW2nJEKjXDd4Ca8Kk+oBapSO4pewSlno3n+OyimcyVJJujQZkBN2D+xuMkIamSc6hA== dependencies: - lodash "^4.17.21" + known-css-properties "^0.29.0" postcss-media-query-parser "^0.2.3" postcss-resolve-nested-selector "^0.1.1" - postcss-selector-parser "^6.0.6" - postcss-value-parser "^4.1.0" + postcss-selector-parser "^6.0.13" + postcss-value-parser "^4.2.0" stylelint@^15.11.0: version "15.11.0" From ee5c98f00602c07352c0a030a9b4e50c31dcf0db Mon Sep 17 00:00:00 2001 From: Rebecca Pearce <17481621+beccapearce@users.noreply.github.com> Date: Fri, 10 Nov 2023 11:08:27 +0000 Subject: [PATCH 2/2] fix linting errors: --- app/assets/stylesheets/components/_autocomplete.scss | 2 +- app/assets/stylesheets/components/_image-cropper.scss | 2 +- app/assets/stylesheets/components/_markdown-guidance.scss | 2 +- app/assets/stylesheets/components/_miller-columns.scss | 6 +++--- app/assets/stylesheets/components/_toolbar-dropdown.scss | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/assets/stylesheets/components/_autocomplete.scss b/app/assets/stylesheets/components/_autocomplete.scss index 0e651e9588..ae2fb28087 100644 --- a/app/assets/stylesheets/components/_autocomplete.scss +++ b/app/assets/stylesheets/components/_autocomplete.scss @@ -63,7 +63,7 @@ $app-focus-colour: $govuk-focus-colour; .autocomplete__option:hover { padding: 5px 6px; - &:before { + &::before { position: relative; top: 3px; padding-top: 2px; diff --git a/app/assets/stylesheets/components/_image-cropper.scss b/app/assets/stylesheets/components/_image-cropper.scss index f8a3f4624f..350d3011cc 100644 --- a/app/assets/stylesheets/components/_image-cropper.scss +++ b/app/assets/stylesheets/components/_image-cropper.scss @@ -14,7 +14,7 @@ $app-cropper-point-size: 20px; .cropper-line, .cropper-point, - .cropper-point.point-se:before { + .cropper-point.point-se::before { background-color: $govuk-focus-colour; } diff --git a/app/assets/stylesheets/components/_markdown-guidance.scss b/app/assets/stylesheets/components/_markdown-guidance.scss index 36143ed8b9..d4e0052605 100644 --- a/app/assets/stylesheets/components/_markdown-guidance.scss +++ b/app/assets/stylesheets/components/_markdown-guidance.scss @@ -35,7 +35,7 @@ .app-c-markdown-guidance__item { list-style: none; - &:before { + &::before { content: "+"; } diff --git a/app/assets/stylesheets/components/_miller-columns.scss b/app/assets/stylesheets/components/_miller-columns.scss index 0087387a10..900d23e5d2 100644 --- a/app/assets/stylesheets/components/_miller-columns.scss +++ b/app/assets/stylesheets/components/_miller-columns.scss @@ -11,12 +11,12 @@ // Remove box-shadow set in govuk-frontend for govuk-checkboxes__input // as we rely on the parent element miller-columns__item to show the target area on hover - .govuk-checkboxes__item:hover .govuk-checkboxes__input:focus + .govuk-checkboxes__label:before, - .govuk-checkboxes__item:hover .govuk-checkboxes__input:not(:disabled) + .govuk-checkboxes__label:before { + .govuk-checkboxes__item:hover .govuk-checkboxes__input:focus + .govuk-checkboxes__label::before, + .govuk-checkboxes__item:hover .govuk-checkboxes__input:not(:disabled) + .govuk-checkboxes__label::before { box-shadow: none; } } -.miller-columns__item--parent:after { +.miller-columns__item--parent::after { margin-top: -15px; } diff --git a/app/assets/stylesheets/components/_toolbar-dropdown.scss b/app/assets/stylesheets/components/_toolbar-dropdown.scss index e0f28b6744..92c6fbe0bd 100644 --- a/app/assets/stylesheets/components/_toolbar-dropdown.scss +++ b/app/assets/stylesheets/components/_toolbar-dropdown.scss @@ -44,7 +44,7 @@ $app-dropdown-arrow-spacing: $app-dropdown-arrow-size / 2; box-shadow: none; } - &:after { + &::after { content: ""; position: relative; top: 4px;