diff --git a/Gemfile.lock b/Gemfile.lock index 41afa3f2c4..6d4a25a638 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -215,7 +215,7 @@ GEM nokogiri (>= 1.6) interactor (3.1.2) jmespath (1.6.2) - json (2.6.3) + json (2.7.1) json-schema (4.1.1) addressable (>= 2.8) json_matchers (0.11.1) @@ -502,8 +502,8 @@ GEM opentelemetry-semantic_conventions opentelemetry-semantic_conventions (1.10.0) opentelemetry-api (~> 1.0) - parallel (1.23.0) - parser (3.2.2.3) + parallel (1.24.0) + parser (3.2.2.4) ast (~> 2.4.1) racc pdf-reader (2.12.0) @@ -592,37 +592,38 @@ GEM rspec-mocks (~> 3.12) rspec-support (~> 3.12) rspec-support (3.12.1) - rubocop (1.55.0) + rubocop (1.59.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) - parser (>= 3.2.2.3) + parser (>= 3.2.2.4) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.28.1, < 2.0) + rubocop-ast (>= 1.30.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.29.0) + rubocop-ast (1.30.0) parser (>= 3.2.1.0) - rubocop-capybara (2.18.0) + rubocop-capybara (2.19.0) rubocop (~> 1.41) - rubocop-factory_bot (2.23.1) + rubocop-factory_bot (2.24.0) rubocop (~> 1.33) - rubocop-govuk (4.12.0) - rubocop (= 1.55.0) - rubocop-ast (= 1.29.0) - rubocop-rails (= 2.20.2) + rubocop-govuk (4.13.0) + rubocop (= 1.59.0) + rubocop-ast (= 1.30.0) + rubocop-rails (= 2.23.0) rubocop-rake (= 0.6.0) - rubocop-rspec (= 2.22.0) - rubocop-rails (2.20.2) + rubocop-rspec (= 2.25.0) + rubocop-rails (2.23.0) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) + rubocop-ast (>= 1.30.0, < 2.0) rubocop-rake (0.6.0) rubocop (~> 1.0) - rubocop-rspec (2.22.0) - rubocop (~> 1.33) + rubocop-rspec (2.25.0) + rubocop (~> 1.40) rubocop-capybara (~> 2.17) rubocop-factory_bot (~> 2.22) ruby-progressbar (1.13.0) @@ -689,7 +690,7 @@ GEM concurrent-ruby (~> 1.0) uglifier (4.2.0) execjs (>= 0.3.0, < 3) - unicode-display_width (2.4.2) + unicode-display_width (2.5.0) version_gem (1.1.3) warden (1.2.9) rack (>= 2.0.9) diff --git a/lib/requirements/form/file_attachment_metadata_checker.rb b/lib/requirements/form/file_attachment_metadata_checker.rb index 2715afc457..2cf3a44a5f 100644 --- a/lib/requirements/form/file_attachment_metadata_checker.rb +++ b/lib/requirements/form/file_attachment_metadata_checker.rb @@ -48,6 +48,6 @@ def invalid_paper_number?(type, params) return :blank if number.blank? regex = "#{self.class}::#{type.upcase}_PAPER_REGEX".constantize - return :invalid unless regex.match?(number) + :invalid unless regex.match?(number) end end diff --git a/spec/views/documents/show.html.erb_spec.rb b/spec/views/documents/show.html.erb_spec.rb index d66da86896..7b1a0aa121 100644 --- a/spec/views/documents/show.html.erb_spec.rb +++ b/spec/views/documents/show.html.erb_spec.rb @@ -14,8 +14,8 @@ expect(rendered) .to include("Summary") - .and have_content(/#{I18n.t!("documents.show.metadata.created_by")}:\s*User 2/) - .and have_content(/#{I18n.t!("documents.show.metadata.last_edited_by")}:\s*User 1/) + .and have_content(/#{I18n.t!('documents.show.metadata.created_by')}:\s*User 2/) + .and have_content(/#{I18n.t!('documents.show.metadata.last_edited_by')}:\s*User 1/) end it "shows a fallback title if there is none" do