Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fill_params_buf infallible #147

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Make fill_params_buf infallible #147

merged 1 commit into from
Nov 16, 2024

Conversation

GrantM11235
Copy link
Contributor

The error variant was never used.

@GrantM11235
Make fill_params_buf infallible
2df07d3 
The error variant was never used.
almindor
almindor approved these changes Nov 16, 2024
View reviewed changes
Copy link
Owner

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice simplification

@almindor almindor merged commit f8b268c into almindor:master Nov 16, 2024
15 checks passed
@GrantM11235 GrantM11235 deleted the infallible-fill-params-buf branch November 16, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almindor almindor almindor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrantM11235 @almindor