Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spi st7789 example for v0.8 #117

Closed
wants to merge 1 commit into from
Closed

fix spi st7789 example for v0.8 #117

wants to merge 1 commit into from

Conversation

almindor
Copy link
Owner

@almindor almindor commented Feb 19, 2024

This is the only one I know how to fix, the others hal packages don't seem to be at eh1 yet.

Related to #99

NOTE: this cannot be merged until v0.8 is released

@rfuest
Copy link
Collaborator

rfuest commented Feb 20, 2024

This is the only one I know how to fix, the others hal packages don't seem to be at eh1 yet.

I don't know about the ESP32 one, but there is e-h 1 support for the pico. The feature to enable support is still called eh1_0_alpha, but the latest release uses the final version of e-h 1.

NOTE: this cannot be merged until v0.8 is released

Because CI is failing? We will need to change CI anyway to make sure it uses the latest development version to build the examples. The simplest solution would be to use path dependencies in the examples. But this would make anyone how just wants to try one of the examples also use the latest development version. I'm not sure if that's a problem, but all solutions I can come up with have some drawback.

@rursprung
Copy link

I don't know about the ESP32 one

you can use the eh1 feature on the latest version of the HAL

Because CI is failing? We will need to change CI anyway to make sure it uses the latest development version to build the examples. The simplest solution would be to use path dependencies in the examples. But this would make anyone how just wants to try one of the examples also use the latest development version. I'm not sure if that's a problem, but all solutions I can come up with have some drawback.

IMHO the path dependency is the best way for such examples - it ensures that you examples always match what's currently in the repo (and anyone looking at the examples is looking at the repo). it's really confusing if the two don't match.

@almindor
Copy link
Owner Author

superseded

@almindor almindor closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants