You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While reviewing #91 I noticed that there is some inconsistency in the dcs module, which we might want to fix as a part of a future breaking change. SetPixelFormat uses a private tuple field and a new constructor, while other types with one parameter use a public tuple field and don't provide a constructor. IMO we should use a private fields and a constructor for all command types with parameters to be consistent.
The text was updated successfully, but these errors were encountered:
While reviewing #91 I noticed that there is some inconsistency in the
dcs
module, which we might want to fix as a part of a future breaking change.SetPixelFormat
uses a private tuple field and anew
constructor, while other types with one parameter use a public tuple field and don't provide a constructor. IMO we should use a private fields and a constructor for all command types with parameters to be consistent.The text was updated successfully, but these errors were encountered: