Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DCS API more consistent #92

Closed
rfuest opened this issue Jan 19, 2024 · 1 comment
Closed

Make DCS API more consistent #92

rfuest opened this issue Jan 19, 2024 · 1 comment

Comments

@rfuest
Copy link
Collaborator

rfuest commented Jan 19, 2024

While reviewing #91 I noticed that there is some inconsistency in the dcs module, which we might want to fix as a part of a future breaking change. SetPixelFormat uses a private tuple field and a new constructor, while other types with one parameter use a public tuple field and don't provide a constructor. IMO we should use a private fields and a constructor for all command types with parameters to be consistent.

@almindor
Copy link
Owner

I agree, but I'm quite busy atm. I can have a look later. Happy to review a PR though.

This should preferably be addressed before e-h 1.0 support so we can have it all in one breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants