feat(protocol): Compressors #299
Open
+458
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
A-protocol
📚
|
This was referenced Nov 21, 2024
refcell
force-pushed
the
rf/chore/move-brotli
branch
from
177a828
to
83f5d1b
Compare
refcell
force-pushed
the
rf/feat/compressors
branch
from
18dfbfa
to
370776c
Compare
refcell
force-pushed
the
rf/chore/move-brotli
branch
from
c26ba4d
to
84fde57
Compare
refcell
force-pushed
the
rf/feat/compressors
branch
2 times, most recently
from
cad0b62
to
317bfa7
Compare
refcell
force-pushed
the
rf/chore/move-brotli
branch
from
84fde57
to
d340778
Compare
refcell
force-pushed
the
rf/feat/compressors
branch
2 times, most recently
from
cabe5ab
to
ea28e34
Compare
mattsse
approved these changes
Nov 22, 2024
Comment on lines
+37
to
+38
| where | ||
| C: Compressor + Clone + core::fmt::Debug, |
There was a problem hiding this comment.
I think you can relax this here entirely
Comment on lines
+59
to
+60
| where | ||
| C: Compressor + Clone + core::fmt::Debug, |
There was a problem hiding this comment.
is clone + debug required here?
There was a problem hiding this comment.
I think so in order for the struct to be Clone + Debug since it's composition
Co-authored-by: Matthias Seitz <[email protected]>
refcell
force-pushed
the
rf/feat/compressors
branch
from
c637b0d
to
c3f66e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces compressors into
op-alloy-protocol, cleaning up the brotli and zlib utility methods as well as theChannelOuttype.