-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(protocol): Move and Extend Brotli Compression #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
mattsse
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
looks like a feature issue in ci
refcell
force-pushed
the
rf/feat/protocol-fixes
branch
2 times, most recently
from
November 21, 2024 19:09
1b4450e
to
5e319f9
Compare
refcell
force-pushed
the
rf/chore/move-brotli
branch
2 times, most recently
from
November 21, 2024 19:16
c26ba4d
to
84fde57
Compare
refcell
force-pushed
the
rf/feat/protocol-fixes
branch
from
November 21, 2024 19:29
5e319f9
to
c3b3087
Compare
refcell
force-pushed
the
rf/chore/move-brotli
branch
from
November 21, 2024 19:35
84fde57
to
d340778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves brotli compression to the correct
brotli
module.Extends the brotli compression method to accept the brotli compression level.
See: https://github.com/ethereum-optimism/optimism/blob/develop/op-node/rollup/derive/types.go#L50