Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol): Move and Extend Brotli Compression #298

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 21, 2024

Description

Moves brotli compression to the correct brotli module.

Extends the brotli compression method to accept the brotli compression level.

See: https://github.com/ethereum-optimism/optimism/blob/develop/op-node/rollup/derive/types.go#L50

@refcell refcell added the A-protocol Area: protocol crate label Nov 21, 2024
@refcell refcell requested a review from emhane as a code owner November 21, 2024 16:26
@refcell refcell added the C-feat Category: New feature or request label Nov 21, 2024
@refcell refcell requested a review from clabby as a code owner November 21, 2024 16:26
@refcell refcell self-assigned this Nov 21, 2024
@refcell
Copy link
Collaborator Author

refcell commented Nov 21, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

looks like a feature issue in ci

@refcell refcell force-pushed the rf/feat/protocol-fixes branch 2 times, most recently from 1b4450e to 5e319f9 Compare November 21, 2024 19:09
@refcell refcell force-pushed the rf/chore/move-brotli branch 2 times, most recently from c26ba4d to 84fde57 Compare November 21, 2024 19:16
Base automatically changed from rf/feat/protocol-fixes to main November 21, 2024 19:36
@refcell refcell added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 3ea6781 Nov 21, 2024
20 checks passed
@refcell refcell deleted the rf/chore/move-brotli branch November 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-protocol Area: protocol crate C-feat Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants