Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-worker don't run in windows. #21

Open
antoniomuso opened this issue Sep 27, 2017 · 5 comments
Open

node-worker don't run in windows. #21

antoniomuso opened this issue Sep 27, 2017 · 5 comments
Assignees
@kwiatkk1
Labels
bug hacktoberfest

Comments

@antoniomuso
Copy link

antoniomuso commented Sep 27, 2017 •
edited
Loading

Hi, In windows os all promise remain in "pending" code, while in linux it works.
@kwiatkk1
Copy link
Contributor

Hey Antonio, thanks for choosing the lib and pointing out this issue!
Do you have node.js installed and run as a regular Windows binary or by using linux subsystem?

@kwiatkk1 kwiatkk1 self-assigned this Sep 28, 2017
@kwiatkk1 kwiatkk1 added the bug label Sep 28, 2017
@antoniomuso
Copy link
Author

I use Windows binary

@kwiatkk1
Copy link
Contributor

OK, I was able to reproduce this on both native node.js binary and "node on ubuntu on windows".
I'm looking for the reason why it's not working... (I'm guessing that the problem may be in a usage of net/fd sockets etc)

@jagu-sayan
Copy link

@antoniomuso @kwiatkk1 Workaround : I don't have this problem with "bash on ubuntu on windows" ;)

dhharker added a commit to dhharker/node-worker-nodes that referenced this issue Aug 28, 2018
@dhharker
allegro#21 do not concat buffers when not on Windows (perf)
e1346ea
dhharker added a commit to dhharker/node-worker-nodes that referenced this issue Aug 28, 2018
@dhharker
Fix issue allegro#21: "node-worker don't run in windows"
14f69a1 
- in transport.send(), only call pipe.write once

Payload of second call (containing `serializedMessage`) was getting lost, or at least not being received.

I could not discern the exact root cause (something something pipes on windows).

Tests are all passing on linux and windows.
dhharker added a commit to dhharker/node-worker-nodes that referenced this issue Aug 28, 2018
@dhharker
allegro#21 do not concat buffers when not on Windows (perf)
5934ed3
dhharker added a commit to dhharker/node-worker-nodes that referenced this issue Aug 28, 2018
@dhharker
WiP Fix issue allegro#21: "node-worker don't run in windows"
7a1a8ab 
- in transport.send(), only call pipe.write once
- do not concat buffers when not on Windows (perf)

Payload of second call (containing `serializedMessage`) was getting lost, or at least not being received.

This appears to have _sort of_ fixed it...

I could not discern the exact root cause (something something pipes on windows).

Tests are still all passing on linux. Some failures on windows.
@just-paja just-paja mentioned this issue Oct 20, 2018
Open
@bgalek
Copy link
Member

bgalek commented May 5, 2021

I've added windows to CI runners, seems ok ;) please try out latest version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwiatkk1 kwiatkk1

Labels
bug hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jagu-sayan @bgalek @kwiatkk1 @antoniomuso